Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-79266

Require language strings for subplugin types be defined

XMLWordPrintable

    • MOODLE_403_STABLE
    • MOODLE_404_STABLE
    • Hide
      1. Revert MDL-79267, e.g. for 'main': 

        $ git revert -m 1 e67c0b87b1

      2. Log in as admin
      3. Purge caches
      4. Navigate to Plugins > Plugins overview in site administration
      5. Confirm you see the following debugging: 

        Invalid get_string() identifier: 'subplugintype_forumreport_plural' or component 'mod_forum'. Perhaps you are missing $string['subplugintype_forumreport_plural'] = ''; in mod/forum/lang/en/forum.php?

      Show
      Revert MDL-79267 , e.g. for ' main ': $ git revert -m 1 e67c0b87b1 Log in as admin Purge caches Navigate to Plugins > Plugins overview in site administration Confirm you see the following debugging: Invalid get_string() identifier: 'subplugintype_forumreport_plural' or component 'mod_forum'. Perhaps you are missing $string['subplugintype_forumreport_plural'] = ''; in mod/forum/lang/en/forum.php?

      See related recent issues MDL-77794, MDL-79236, MDL-78946 & MDL-79267 - missing language strings are simply masked here: https://github.com/moodle/moodle/blob/206c3a66e77ceb153e5b5c6af22585e819f5d124/lib/classes/plugin_manager.php#L629-L634 - which means they show technical terms in the UI, and cannot be translated

      To prevent new MDL bug reports similar to the above popping up, I propose requiring the language string always (rather than masking its absence). This makes missing language string more obvious because a developer debugging message is emitted

        1. MDL-79266.png
          MDL-79266.png
          158 kB

            pholden Paul Holden
            pholden Paul Holden
            Stevani Andolo Stevani Andolo
            Huong Nguyen Huong Nguyen
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            0 Vote for this issue
            Watchers:
            10 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 35 minutes
                1h 35m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.