Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-79313

Deprecate unused \calendar_top_controls()

XMLWordPrintable

    • MOODLE_403_STABLE
    • MOODLE_403_STABLE
    • MDL-79313-master
    • Hide

      Behat tests should be enough to test this.

      However, a quick exploratory test should be fine:

      1. Go to the calendar
      2. Create a few events
      3. Switch to Month or Day views of the calendar
      4. Confirm that the calendar looks okay and that you don't see any errors on the page.
      5. Confirm that the arrow links work okay and that you can switch the month/day using these arrow links
      Show
      Behat tests should be enough to test this. However, a quick exploratory test should be fine: Go to the calendar Create a few events Switch to Month or Day views of the calendar Confirm that the calendar looks okay and that you don't see any errors on the page. Confirm that the arrow links work okay and that you can switch the month/day using these arrow links

      \calendar_top_controls() is being used by \core_calendar\external\day_exporter() for its navigation context data. However, the navigation context data is not being used anywhere within the calendar templates. So there's really no point adding this context data. Removing this will also mean that calendar_top_controls() will no longer be used and is better suited to be deprecated.

        1. (1) Passed -- (Master)MDL-79313.png
          (1) Passed -- (Master)MDL-79313.png
          68 kB

            jpataleta Jun Pataleta
            jpataleta Jun Pataleta
            Paul Holden Paul Holden
            Huong Nguyen Huong Nguyen
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 27 minutes
                1h 27m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.