Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-79334

Badge report has invalid redirect URL after table reload action

XMLWordPrintable

    • MOODLE_403_STABLE
    • MOODLE_403_STABLE
    • Hide
      1. Log in as admin
      2. Navigate to Manage badges in site administration
      3. Create a new badge
        • Name: Badgers
      4. Add Badge criteria: Manually issues by role
      5. Select Manager and save
      6. Do not press Enable access (yet)
      7. Navigate back to Manage badges in site administration
      8. Open Filters
        • Name is equal to: Badgers
        • Press Apply
      9. Select Actions > Enable access from the report table for your badge
      10. Confirm that you do want to enable access
      11. Confirm you are now back at the site Manage badges page
      12. Create a course
      13. Add a course badge
      14. Add a criteria (same as you did before)
      15. Navigate back to course Manage badges
      16. Select Actions > Enable access from the report table for your badge
      17. Confirm that you do want to enable access
      18. Confirm you are now back at the course Manage badges page
      Show
      Log in as admin Navigate to Manage badges in site administration Create a new badge Name: Badgers Add Badge criteria: Manually issues by role Select Manager and save Do not press Enable access (yet) Navigate back to Manage badges in site administration Open Filters Name is equal to: Badgers Press Apply Select Actions > Enable access from the report table for your badge Confirm that you do want to enable access Confirm you are now back at the site Manage badges page Create a course Add a course badge Add a criteria (same as you did before) Navigate back to course Manage badges Select Actions > Enable access from the report table for your badge Confirm that you do want to enable access Confirm you are now back at the course Manage badges page

      Table reload actions (e.g. paging, sorting, filtering) are executed via AJAX requests, so when we refer to qualified_me() here we are getting back the WS endpoint, and producing a URL like this:

      http://localhost:8000/badges/action.php?id=1&sesskey=KlFF4p8KLw&activate=1&return=%2Flib%2Fajax%2Fservice.php%3Fsesskey%3DKlFF4p8KLw%26info%3Dcore_table_get_dynamic_table_content

      Subsequently clicking the action, eventually redirects you to /lib/ajax/service.php with an error, instead of redirecting you back to where you originated

      This was mentioned in point 11 here but we missed this last remaining case (my bad)

        1. MDL-79334.png
          MDL-79334.png
          279 kB

            pholden Paul Holden
            pholden Paul Holden
            David Carrillo David Carrillo
            Ilya Tregubov Ilya Tregubov
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 30 minutes
                1h 30m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.