Loading...

XML

Word

Printable

Type: Improvement
Resolution: Fixed
Priority: Major
Fix Version/s: 4.3
Affects Version/s: 4.3
Component/s: General
Labels:
- ci

Affected Branches:
MOODLE_403_STABLE
Fixed Branches:
MOODLE_403_STABLE
Pull from Repository:
https://github.com/skodak/moodle.git
Pull Main Branch:
~~MDL-79336~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/master...skodak:moodle:MDL-79336
Testing Instructions:

Hide

the stoppable trait and interface are now covered by PHPUnit tests, there is no way to test it manually

note that there will be more tests for primary_extend hook in ~~MDL-79338~~

Show
the stoppable trait and interface are now covered by PHPUnit tests, there is no way to test it manually note that there will be more tests for primary_extend hook in MDL-79338

See the new \core\hook\navigation\primary_extend hook, the code for stoppable interface would have to be copied over each time we add something with stoppable interface.

The idea is to add a trait to simplify adding of future stoppable hooks.

has to be done after

MDL-79088 Create hooks for adding items to the site primary navigation

Closed

has to be done before

MDL-79338 add support for hook callback redirection in tests

Closed

Assignee:: Petr Skoda

Reporter:: Petr Skoda

Peer reviewer:: Farhan Karmali

Integrator:: Ilya Tregubov

Tester:: CiBoT

Participants:: CiBoT, Eloy Lafuente (stronk7), Farhan Karmali, Ilya Tregubov, Marina Glancy, Petr Skoda

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Created:: 12/Sep/23 10:52 PM

Updated:: 20/Feb/24 11:27 PM

Resolved:: 20/Sep/23 9:47 AM

Estimated:

Not Specified

Remaining:

Logged:

15m

Details

Description

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify