Loading...

XML

Word

Printable

Type: Bug
Resolution: Unresolved
Priority: Minor
Fix Version/s: None
Affects Version/s: 4.1.5
Component/s: General
Labels:
- patch

Affected Branches:
MOODLE_401_STABLE
Pull from Repository:
https://github.com/jrchamp/moodle
Pull 4.1 Branch:
MDL-79361_401
Pull 4.1 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_401_STABLE...jrchamp:moodle:MDL-79361_401
Pull Main Branch:
MDL-79361
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/83b4c96cad3...jrchamp:moodle:MDL-79361
Testing Instructions:

Hide

The cloud-based tests will pass either way because they control the entire environment. So you'll need to have a local webserver that that responds with HTTP/2 or HTTP/3.

php admin/tool/phpunit/cli/init.php

vendor/phpunit/phpunit/phpunit --filter filelib_test

Show
The cloud-based tests will pass either way because they control the entire environment. So you'll need to have a local webserver that that responds with HTTP/2 or HTTP/3. php admin/tool/phpunit/cli/init.php vendor/phpunit/phpunit/phpunit --filter filelib_test

This is a follow up to ~~MDL-79341~~ (where relying on the HTTP status message, when the endpoint uses HTTP/2 protocol causes test failures) - the difference can be seen below in the response headers:

HTTP/1.1 200 OK
HTTP/2 200

Ensure that code similar to this is examined and corrected where necessary

See also brendanheywood's comment here from the same issue

Discovered while testing

MDL-79341 core\filelib_test test curl useragent fails if the request uses http2 instead of http

Closed

has been marked as being related by

MDL-79477 test_network_features() - Failed asserting that -1 is greater than 0.

Closed

will help resolve

MDL-83293 PHPUnit failures on Windows introduced during the Moodle 4.5 development cycle

Closed

Assignee:: Jonathan Champ

Reporter:: Paul Holden

Participants:: Alexander Van der Bellen, CiBoT, Eloy Lafuente (stronk7), Jonathan Champ, Jun Pataleta, Paul Holden

Votes:: 1 Vote for this issue

Watchers:: 17 Start watching this issue

Created:: 14/Sep/23 8:57 PM

Updated:: 11/Dec/24 11:45 PM

Estimated:

Not Specified

Remaining:

Logged:

55m

Details

Description

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify