Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-79432

Deprecate other unused calendar functions

    XMLWordPrintable

Details

    • Task
    • Resolution: Fixed
    • Minor
    • 4.3
    • 4.3
    • Calendar
    • MOODLE_403_STABLE
    • MOODLE_403_STABLE
    • MDL-79432-master
    • Hide
      Codebase search
      1. Open a terminal
      2. Run the following command:

        git grep calendar_get_link_next
        

      3. Confirm that you only get the following results
        • 5 instances from calendar/lib.php
        • 1 instance from calendar/upgrade.txt
      4. Do the same for "calendar_get_link_previous"
      5. Confirm that you only get the following results
        • 5 instances from calendar/lib.php
        • 1 instance from calendar/upgrade.txt
      Quick deprecation message test
      1. Download caltest.php to your moodle instance's root folder.
      2. Turn developer mode on ("mdk run mindev")
      3. Open caltest.php on your browser ([your_moodle_url]/caltest.php)
      4. Confirm that the Next and Previous links are rendered but you also see debugging message that calendar_get_link_previous and calendar_get_link_next have been deprecated.
      Show
      Codebase search Open a terminal Run the following command: git grep calendar_get_link_next Confirm that you only get the following results 5 instances from calendar/lib.php 1 instance from calendar/upgrade.txt Do the same for " calendar_get_link_previous " Confirm that you only get the following results 5 instances from calendar/lib.php 1 instance from calendar/upgrade.txt Quick deprecation message test Download caltest.php to your moodle instance's root folder. Turn developer mode on (" mdk run mindev ") Open caltest.php on your browser ( [your_moodle_url] /caltest.php) Confirm that the Next and Previous links are rendered but you also see debugging message that calendar_get_link_previous and calendar_get_link_next have been deprecated.

    Description

      We have some calendar functions that will no longer be used with calendar_top_controls() now deprecated. These are:

      • calendar_get_link_previous()
      • calendar_get_link_next()

      We need to deprecate these as well.

      Attachments

        Issue Links

          Activity

            People

              jpataleta Jun Pataleta
              jpataleta Jun Pataleta
              Paul Holden Paul Holden
              Sara Arjona (@sarjona) Sara Arjona (@sarjona)
              Kim Jared Lucas Kim Jared Lucas
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 14 minutes
                  1h 14m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.