Loading...

XML

Word

Printable

Type: Task
Resolution: Fixed
Priority: Minor
Fix Version/s: 5.0
Affects Version/s: 4.3
Component/s: Calendar
Labels:
- ci
- release_notes
- triaged

Affected Branches:
MOODLE_403_STABLE
Fixed Branches:
MOODLE_500_STABLE
Epic Link:
5.0 deprecations
Pull from Repository:
https://github.com/ziegenberg/moodle
Pull Main Branch:
~~MDL-79434~~_final-deprecation-of-calendar-functions
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...ziegenberg:MDL-79434_final-deprecation-of-calendar-functions

Testing Instructions:

Hide

Run the following commands:

git grep -C2 'calendar_top_controls('

git grep -C2 'calendar_get_link_previous('

git grep -C2 'calendar_get_link_next('

Verify only the function stubs and the mentions in the upgrade notes come up.

Show

Run the following commands: git grep -C2 'calendar_top_controls(' git grep -C2 'calendar_get_link_previous(' git grep -C2 'calendar_get_link_next(' Verify only the function stubs and the mentions in the upgrade notes come up.

Pre-check results:
Hide

Code verified against automated checks with warnings.

Checked ~~MDL-79434~~ using repository: https://github.com/ziegenberg/moodle

main (0 errors / 1 warnings) [branch: MDL-79434_final-deprecation-of-calendar-functions | CI Job]

overview (0/1), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Warn: the branch is based off integration.git

Should these errors be fixed?

Built on: Wed Mar 12 09:57:45 UTC 2025
Show
Code verified against automated checks with warnings. Checked MDL-79434 using repository: https://github.com/ziegenberg/moodle main (0 errors / 1 warnings) [branch: MDL-79434_final-deprecation-of-calendar-functions | CI Job ] overview (0/1) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Warn: the branch is based off integration.git Should these errors be fixed? Built on: Wed Mar 12 09:57:45 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-79434~~_final-deprecation-of-calendar-functions

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18530/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63470/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63471/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63472/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63473/ App tests (stable app version) --> unrelated app failure, please ignore.

Built on: Wed Mar 12 00:25:17 UTC 2025
Show
Launching automatic jobs for branch MDL-79434 _final-deprecation-of-calendar-functions https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18530/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63470/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63471/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63472/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63473/ App tests (stable app version) --> unrelated app failure, please ignore. Built on: Wed Mar 12 00:25:17 UTC 2025

This task is to track the final deprecation of the following calendar functions deprecated in Moodle 4.3:

calendar_top_controls()
calendar_get_link_previous()
calendar_get_link_next()

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

result.png
1.23 MB
14/Mar/25 3:58 PM

has been marked as being related by

MDL-83873 Create a “human date” output classes

Closed

MDL-84617 Deprecation of legacy/deprecated calendar functions

Closed

has to be done after

MDL-79313 Deprecate unused \calendar_top_controls()

Closed

MDL-79432 Deprecate other unused calendar functions

Closed

has to be done before

MDL-84655 Final deprecation of calendar_sub/add_month()

Open

MDL-84657 Deprecate calendar_add_month()

Closed

(1 has to be done before)

Assignee:: Daniel Ziegenberg

Reporter:: Jun Pataleta

Peer reviewer:: Paul Holden

Integrator:: Huong Nguyen

Tester:: Huong Nguyen

Participants:: CiBoT, Daniel Ziegenberg, Huong Nguyen, Jun Pataleta, Paul Holden, Safat Shahin

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Created:: 20/Sep/23 11:41 PM

Updated:: 11/Apr/25 6:01 PM

Resolved:: 14/Mar/25 11:32 PM

Estimated:

Not Specified

Remaining:

Logged:

1h 16m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify