Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-79442

Tool launch container not honoured when creating activities via the multi-content-item flow

XMLWordPrintable

    • MOODLE_403_STABLE
    • MOODLE_403_STABLE
    • MDL-79442-master
    • Hide
      1. Make your site public, e.g. ngrok or similar
      2. Go to "Site admin > Plugins > Activity plugins > External tool > Manage tools"
      3. Enter https://robotest.theedtech.dev/register and click "Add LTI Advantage"
      4. Activate the tool when you've completed the registration
      5. Edit the tool and set "Tool configuration usage" to "Show in activity chooser and as a preconfigured tool"
      6. Make sure "Default launch container" is set to "Embed (without blocks)", which should be the default
      7. Save.
      8. Go to a course
      9. In an empty section, click to add a new activity, selecting "Robotest" when prompted
      10. Click "Select content"
      11. When the modal loads, click "One of each please" (the far right option)
      12. Now, continue to save the next page
      13. When you're back on course home, notice that you now have 4 activities in that section
      14. Launch the one that contains "Not graded (new win)" in the title
        Verify The tool launches in embedded view, per the default launch container specified in the tool configuration.
      Show
      Make your site public, e.g. ngrok or similar Go to "Site admin > Plugins > Activity plugins > External tool > Manage tools" Enter https://robotest.theedtech.dev/register and click "Add LTI Advantage" Activate the tool when you've completed the registration Edit the tool and set "Tool configuration usage" to "Show in activity chooser and as a preconfigured tool" Make sure "Default launch container" is set to "Embed (without blocks)", which should be the default Save. Go to a course In an empty section, click to add a new activity, selecting "Robotest" when prompted Click "Select content" When the modal loads, click "One of each please" (the far right option) Now, continue to save the next page When you're back on course home, notice that you now have 4 activities in that section Launch the one that contains "Not graded (new win)" in the title Verify The tool launches in embedded view, per the default launch container specified in the tool configuration.
    • 1

      I noticed this when testing MLDQA-18414. Now (4.3 onwards) the tool value is supposed to trump the value included in the content item return, always. This is the case when creating a single item, but when using the multiple-item flow, the instance data must be set incorrectly, meaning that per-instance values of the launch container are still supported. They shouldn't be.

      To replicate:

      1. Make your site public, e.g. ngrok or similar
      2. Go to "Site admin > Plugins > Activity plugins > External tool > Manage tools"
      3. Enter https://robotest.theedtech.dev/register and click "Add LTI Advantage"
      4. Activate the tool when you've completed the registration
      5. Edit the tool and set "Tool configuration usage" to "Show in activity chooser and as a preconfigured tool"
      6. Make sure "Default launch container" is set to "Embed (without blocks)", which should be the default
      7. Save.
      8. Go to a course
      9. In an empty section, click to add a new activity, selecting "Robotest" when prompted
      10. Click "Select content"
      11. When the modal loads, click "One of each please" (the far right option)
      12. Now, continue to save the next page
      13. When you're back on course home, notice that you now have 4 activities in that section
      14. Launch the one that contains "Not graded (new win)" in the title
        Expected The tool launches in embedded view, per the default launch container
        Actual The tool launches in a new window 

            jaked Jake Dallimore
            jaked Jake Dallimore
            Simey Lameze Simey Lameze
            Jun Pataleta Jun Pataleta
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 50 minutes
                1h 50m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.