-
Bug
-
Resolution: Fixed
-
Minor
-
4.1.5, 4.2.2
-
MOODLE_401_STABLE, MOODLE_402_STABLE
-
MOODLE_401_STABLE, MOODLE_402_STABLE
-
MDL-79463-401 -
In the frame of the development of surveypro (https://github.com/kordan/moodle-mod_surveypro) I pushed a branch to github.
In https://github.com/kordan/moodle-mod_surveypro/actions/runs/6244401346/job/16951247619 (using php 7.4)
or https://github.com/kordan/moodle-mod_surveypro/actions/runs/6235196000/job/16923914715 (using php 8)
I read:
test (7.4, MOODLE_401_STABLE, mariadb, default, default)
or
test (8, MOODLE_401_STABLE, pgsql, classic, chrome)
RUN Mustache Lint on mod_surveypro
/home/runner/work/moodle-mod_surveypro/moodle-mod_surveypro/moodle/mod/surveypro/templates/view_action_bar.mustache
WARNING: ESLint warning [consistent-return]: Expected to return a value at the end of function. ( $('#url_select_test').on(CustomEvents.events.accessibleChange, function() {
if (!$(this).val())
$('#url_select_form').submit();
});
}); ), Line: 4 Column: 76
/home/runner/work/moodle-mod_surveypro/moodle-mod_surveypro/moodle/mod/surveypro/templates/view_action_bar.mustache
WARNING: ESLint error [no-trailing-spaces]: Trailing spaces not allowed. ( ), Line: 11 Column: 1
Error: Process completed with exit code 1.
The first warning is related to the core code in /lib/templates/url_select.mustache but forces non core tests (and maybe more) to fail.