Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-79464

Assignment form validation failure allows navigation away without saving

XMLWordPrintable

    • MOODLE_401_STABLE, MOODLE_403_STABLE
    • MDL-79464-MOODLE_401_STABLE
    • MDL-79464-master
    • Hide
      1. Create a course with a teacher and two enrolled students
      2. Add an assignment to the course and configure it to use a marking guide
      3. Add a marking guide to the assignment, with a couple of criterions that have 50 for maximum score
      4. Sign in as the teacher and navigate to the grading screen
      5. Enter feedback and a score for Criterion 1, but not Criterion 2, save changes and verify that a red warning "toast" alert is posted to the top of the screen and remains visible for 8 seconds
      6. Attempt to change user by clicking on the "next" arrow in the top right and verify that a modal warning the user about losing unsaved work appears
      7. Click on "Save and continue" and observe that the grading panel is reloaded and the alert reiterated
      8. Add a remark and score for Criterion 2 and verify that the grade now saves successfully|

      Attempt again to navigate to the next user and observe that this now works

      Show
      Create a course with a teacher and two enrolled students Add an assignment to the course and configure it to use a marking guide Add a marking guide to the assignment, with a couple of criterions that have 50 for maximum score Sign in as the teacher and navigate to the grading screen Enter feedback and a score for Criterion 1, but not Criterion 2, save changes and verify that a red warning "toast" alert is posted to the top of the screen and remains visible for 8 seconds Attempt to change user by clicking on the "next" arrow in the top right and verify that a modal warning the user about losing unsaved work appears Click on "Save and continue" and observe that the grading panel is reloaded and the alert reiterated Add a remark and score for Criterion 2 and verify that the grade now saves successfully| Attempt again to navigate to the next user and observe that this now works

      On the assignment activity. Particularly when using advanced grading (e.g. rubrics) if user attempts to save but the save fails, it is not clear that the failure happens and the error message is not focussed so easily missed. The user can then navigate away from the grading screen without any warning that the work will be lost and thereby losing all grading and feedback.

      Reproduce:

      1. Create a course with 1 teacher and 2 students
      2. as teacher, create an assignment activity and enable a rubric with some criteria and feedback comments
      3. as a teacher, attempt to grade the student, but only partially complete the rubric.
      4. Add some feedback comments
      5. Click save.
      6. There is no visual indication of failure of the save and the red validation text on the rubric is not brought into focus
      7. navigate to student 2 and observe that no warning is given before leaving the page
      8. return to student 1 and observe that all the grading added has been lost.

      Also confirmed on 4.3 on qa.moodle.net

            Unassigned Unassigned
            timellis Tim Ellis
            Mihail Geshoski Mihail Geshoski
            Votes:
            5 Vote for this issue
            Watchers:
            12 Start watching this issue

              Created:
              Updated:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours
                2h

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.