Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-79466

Question bank filters not applied correctly on history view

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 4.3
    • 4.3
    • Questions
    • MOODLE_403_STABLE
    • MOODLE_403_STABLE
    • MDL-79466_master
    • Hide

      Covered by behat tests in question_history_action.feature

      Manual steps:

      1. Create a course.
      2. Go to the question bank
      3. Create a new course category
      4. Create a new question and add it to the course category
      5. Go back to the course page and access the question bank again, so you see the default view with the default category selected.
      6. Set the Category filter to the category you created, and click "Apply filters"
        • You should see your question.
      7. From your question's "Edit" menu, select "History"
        • You should be taken to the Question history page for your question
        • Confirm you see your question's versions listed (there will probably only be one unless you edited it after creation).
        • Before fix: You did not see the question versions
        • Confirm you do not see the filter UI at the top of the page.
        • Before fix: You did see the filter UI at the top of the page, with the default category selected.
      8. Click "Close" in the top-right.
        • You should return to the normal question bank view.
        • Your category should be selected in the Category filter.
        • Your question should be visible.
      Show
      Covered by behat tests in question_history_action.feature Manual steps: Create a course. Go to the question bank Create a new course category Create a new question and add it to the course category Go back to the course page and access the question bank again, so you see the default view with the default category selected. Set the Category filter to the category you created, and click "Apply filters" You should see your question. From your question's "Edit" menu, select "History" You should be taken to the Question history page for your question Confirm you see your question's versions listed (there will probably only be one unless you edited it after creation). Before fix: You did not see the question versions Confirm you do not see the filter UI at the top of the page. Before fix : You did see the filter UI at the top of the page, with the default category selected. Click "Close" in the top-right. You should return to the normal question bank view. Your category should be selected in the Category filter. Your question should be visible.

      As discussed on MDL-79224, viewing the history of a question in a non-default category does not work correctly, as the filter values are not carried through to the history page. The means you have to re-select the category to see the question.

      It doesn't make a lot of sense to display the filter UI on this page, since changing the category from the correct one will result in nothing being displayed, and "Show hidden questions" would either show everything or nothing.

      "Tags" will still operate as expected, since versions may have different tags, so it may be worth keeping the filter UI present for that, and for other filters added in the future.

        1. MDL-79466.png
          552 kB
          Ron Carl Alfon Yu

            marxjohnson Mark Johnson
            marxjohnson Mark Johnson
            Tim Hunt Tim Hunt
            Jake Dallimore Jake Dallimore
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 39 minutes
                39m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.