Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-79485

Hard-coded English language strings in MFA verification page

    XMLWordPrintable

Details

    • MOODLE_403_STABLE
    • MOODLE_403_STABLE
    • Hide
      1. Log in as admin
      2. Navigate to Language > Language customisation in site administration
      3. Choose English > Open language pack for editing
      4. Set Show strings of these components to tool_mfa.php and press Show strings
      5. Change the following, then save:
        • cancellogin: "Cancel login (edited)"
        • needhelp: "Need help? (edited)"
      6. Navigate to Plugins > Admin tools > Manage multi-factor authentication in site administration
      7. Enable the Email factor type
      8. Under General MFA settings select MFA plugin enabled and save
      9. Log out
      10. Log in as admin
      11. On 2-step verification page:
        • Confirm presence of Cancel login (edited) button
        • Confirm presence of Need help? (edited) text
      Show
      Log in as admin Navigate to Language > Language customisation in site administration Choose English > Open language pack for editing Set Show strings of these components to tool_mfa.php and press Show strings Change the following, then save: cancellogin: "Cancel login (edited)" needhelp: "Need help? (edited)" Navigate to Plugins > Admin tools > Manage multi-factor authentication in site administration Enable the Email factor type Under General MFA settings select MFA plugin enabled and save Log out Log in as admin On 2-step verification page: Confirm presence of Cancel login (edited) button Confirm presence of Need help? (edited) text
    • 1
    • Team Hedgehog 2023 Sprint 3.3

    Description

      As reported by dinism (thanks ) here (from MDL-78534):

      There are some strings hardcoded to english:

      Cancel login

      <form id="cancelmfa" method="POST" action="

      Unknown macro: {authurl}

      ">
      <input type="hidden" id="uniqid-logout" name="logout" value="true">
      <input type="submit" class="btn btn-secondary"
      name="cancelmfa" id="cancelmfa_button"
      value="Cancel login" data-initial-value="Cancel login">

      </form>

      https://github.com/moodle/moodle/blob/9890e67e6d262a0a5eb938bc3b007045fe067ec9/admin/tool/mfa/templates/verification_form.mustache#L88

      Need help

      <div class="tool-mfa-site-support mt-4">
      Need help?

      Unknown macro: {supportlink}

      </div>

      https://github.com/moodle/moodle/blob/9890e67e6d262a0a5eb938bc3b007045fe067ec9/admin/tool/mfa/templates/verification_form.mustache#L93

      Attachments

        Issue Links

          Activity

            People

              pholden Paul Holden
              pholden Paul Holden
              Meirza Meirza
              Jun Pataleta Jun Pataleta
              Kim Jared Lucas Kim Jared Lucas
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 40 minutes
                  40m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.