Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-79548

String problems with MoodleNet

    XMLWordPrintable

Details

    • MOODLE_403_STABLE
    • MOODLE_403_STABLE
    • MDL-79548-master
    • Hide

      I'm not sure that we can test the non-English string since the lang pack won't be updated with the changes, but the below testing confirms that the English shown in the UI remains unchanged, and code review will confirm that the change removes the reliance on nested parts of the strings, which resolves the issue.

      Note: If you have the MoodleNet mock configured (docker setup and define('TEST_MOODLENET_MOCK_SERVER', 'https://moodlenet.test'); set up in config.php), this is also covered by existing behat tests, which you will need to run locally for all of the lib/tests/behat/moodlenet*_ feature files.

      Manual steps:

      Setup/prerequisites

      1. Have a course with a teacher and at least 2 activities.
      2. As an admin, visit <wwwroot>/admin/tool/oauth2/issuers.php.
      3. Click the MoodleNet button.
      4. Set the name to "MoodleNet prototype" and the _Service base URL to "https://mn3-prototype.moodle.net/" and save.
      5. Go to Site admin > Development > Experimental > Experimental settings.
      6. Enable Enable sharing to MoodleNet (outbound) and save.
      7. Go to Site admin > General > MoodleNet > MoodleNet outbound settings.
      8. Set OAuth2 service to "MoodleNet prototype" and save.

      Test - Confirming English strings appear unchanged in the UI

      1. Log in as teacher and navigate to the course.
      2. From the course More menu, select Share to MoodleNet.
      3. CONFIRM the text in the modal reads "This course is being shared with MoodleNet as a resource.".
      4. Press Cancel.
      5. Still on the course homepage, enable Edit mode if it is not already on, then press Bulk actions.
      6. Select exactly one activity, then press Share to MoodleNet at the bottom of the page.
      7. CONFIRM the text in the modal reads "This activity is being shared with MoodleNet as a resource.".
      8. Press Cancel.
      9. Select more than one activity, then again press Share to MoodleNet.
      10. CONFIRM the text in the modal reads "The selected activities are being shared with MoodleNet as a resource." and CONFIRM the number of activities listed in bold matches the number you selected.
      11. Press Cancel.
      12. Navigate into one of the activities in the course.
      13. In the activity's More menu, select Share to MoodleNet.
      14. CONFIRM the text in the modal reads "This activity is being shared with MoodleNet as a resource.".
      Show
      I'm not sure that we can test the non-English string since the lang pack won't be updated with the changes, but the below testing confirms that the English shown in the UI remains unchanged, and code review will confirm that the change removes the reliance on nested parts of the strings, which resolves the issue. Note: If you have the MoodleNet mock configured ( docker setup and define('TEST_MOODLENET_MOCK_SERVER', 'https://moodlenet.test'); set up in config.php), this is also covered by existing behat tests, which you will need to run locally for all of the lib/tests/behat/moodlenet *_ feature files. Manual steps: Setup/prerequisites Have a course with a teacher and at least 2 activities. As an admin, visit <wwwroot>/admin/tool/oauth2/issuers.php. Click the MoodleNet button. Set the name to "MoodleNet prototype" and the _Service base URL to "https://mn3-prototype.moodle.net/" and save. Go to Site admin > Development > Experimental > Experimental settings. Enable Enable sharing to MoodleNet (outbound) and save. Go to Site admin > General > MoodleNet > MoodleNet outbound settings. Set OAuth2 service to "MoodleNet prototype" and save. Test - Confirming English strings appear unchanged in the UI Log in as teacher and navigate to the course. From the course More menu, select Share to MoodleNet . CONFIRM the text in the modal reads "This course is being shared with MoodleNet as a resource.". Press Cancel . Still on the course homepage, enable Edit mode if it is not already on, then press Bulk actions . Select exactly one activity, then press Share to MoodleNet at the bottom of the page. CONFIRM the text in the modal reads "This activity is being shared with MoodleNet as a resource.". Press Cancel . Select more than one activity, then again press Share to MoodleNet . CONFIRM the text in the modal reads "The selected activities are being shared with MoodleNet as a resource." and CONFIRM the number of activities listed in bold matches the number you selected. Press Cancel . Navigate into one of the activities in the course. In the activity's More menu, select Share to MoodleNet . CONFIRM the text in the modal reads "This activity is being shared with MoodleNet as a resource.".
    • 2
    • Team Hedgehog 2023 Sprint 3.3

    Description

      I noticed when doing some docs screenshots for the Francophone community that part of string moodlenet:sharenotice does not translate into French. It continues to say "course" in English. In conversation with French lang pack maintainer mina it seems that the rule "Strings should not be designed for UI concatenation, as it may cause problems in other languages. Each string should stand alone."
      has not been followed, meaning that it is not possible to translate the term into other languages.
      It will help our volunteer translators if this can be fixed thankyou.

      Attachments

        1. (1) 10 Passed -- (Master)MDL-79548.png
          (1) 10 Passed -- (Master)MDL-79548.png
          30 kB
        2. (1) 14 Passed -- (Master)MDL-79548.png
          (1) 14 Passed -- (Master)MDL-79548.png
          24 kB
        3. (1) 3 Passed -- (Master)MDL-79548.png
          (1) 3 Passed -- (Master)MDL-79548.png
          25 kB
        4. (1) 7 Passed -- (Master)MDL-79548.png
          (1) 7 Passed -- (Master)MDL-79548.png
          25 kB
        5. fr_01.png
          fr_01.png
          17 kB
        6. fr_02.png
          fr_02.png
          12 kB
        7. MDL-79548_Step10.png
          MDL-79548_Step10.png
          30 kB
        8. MDL-79548_Step14.png
          MDL-79548_Step14.png
          26 kB
        9. MDL-79548_Step3.png
          MDL-79548_Step3.png
          25 kB
        10. MDL-79548_Step7.png
          MDL-79548_Step7.png
          27 kB
        11. QA_18434_IndividualActivity_6.png
          QA_18434_IndividualActivity_6.png
          43 kB

        Issue Links

          Activity

            People

              michaelh Michael Hawkins
              marycooch Mary Cooch
              Raquel Ortega Raquel Ortega
              Huong Nguyen Huong Nguyen
              Kim Jared Lucas Kim Jared Lucas
              Votes:
              3 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 7 hours, 17 minutes
                  7h 17m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.