-
Bug
-
Resolution: Unresolved
-
Minor
-
None
-
4.1.6, 4.2.3, 4.3, 4.4.4
-
MOODLE_401_STABLE, MOODLE_402_STABLE, MOODLE_403_STABLE, MOODLE_404_STABLE
-
2
-
Moppies PB candidates
While working on MDL-75572 and MDL-79367, to update the behaviour of the failed grade activity completion when using it in badges or restrictions, I've seen the current "Passing grade or all available attempts completed" is not working as expected because the current Activity completion API doesn't implement a method to combine the state of several conditions.
Although the code in quiz_attempt_submitted_handler() in mod/quiz/locallib.php is updating the state to COMPLETION_COMPLETE, the update_state() method is not changing it properly.
While discussing this issue with Amaia we thought that it might be fixed by moving the "Passing grade or all available attempts completed" option outside the Passing grade, to remove the restriction that currently exists between these conditions and leaving them as they were before the changes done in 4.3.
- has been marked as being related by
-
MDL-79367 Activity access restrictions do not work when using activity completion with passing grade criteria and failed grade is given
- Closed
-
MDL-75572 Badges using activity completion with passing grade criteria, even when failed grade is given
- Closed
-
MDL-80102 overallcompletion ignores possible completion states
- Closed
- is a regression caused by
-
MDL-52206 Move "Require passing grade" completion option to core
- Closed
- is duplicated by
-
MDL-80916 Remove the word "Or" from the text "Or all available attempts completed" in the quiz activity completion
- Closed
-
MDL-82153 Course completion criteria COMPLETION_CRITERIA_TYPE_ACTIVITY and Quiz
- Closed
-
MDL-82176 Completion tracking setting "Passing grade OR all available attempts completed" do not work properly
- Closed