Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Critical
Fix Version/s: 4.3.1
Affects Version/s: 4.3
Component/s: Activity completion
Labels:
- MEC
- affects_academy
- ci
- developer_notes
- hqteam_moppies
- regression
- release_notes
- triaged

Affected Branches:
MOODLE_403_STABLE
Fixed Branches:
MOODLE_403_STABLE
Pull from Repository:
https://github.com/sarjona/moodle.git
Pull 4.3 Branch:
~~MDL-79726~~-403
Pull 4.3 Diff URL:
https://github.com/sarjona/moodle/compare/a418e9e53a...MDL-79726-403
Pull Main Branch:
~~MDL-79726~~-main
Pull Main Diff URL:
https://github.com/sarjona/moodle/compare/abba174fe1...MDL-79726-main
Testing Instructions:

Hide

Covered by PHPUnit and Behat tests.

Show
Covered by PHPUnit and Behat tests.

Sprint:
HQ 2023 Sprint I4.2 Moppies

To reproduce:

Create a course with completion tracking enabled
Create an assignment within that course and set a passing grade and the activity completion condition to "Receive a grade"
Save the changes
Grade a student s1 with a failing grade
Grade another student s2 with a passing grade
On another browser session, log in as s1 (failing grade) and go to the course homepage
- Expected: You should see "Done"
- Actual: It is set to "To do"
Log out and then log in as s2 (passing grade) and go to the course homepage.
- Expected: You should see "Done"
- Actual: It is also set to "To do"

More info:

If you set the completion condition to "View", and view it as a student, the activity will actually be marked as "Done"

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

AcademyExample.png
36 kB
28/Nov/23 9:19 PM
MDL-79726.png
171 kB
06/Dec/23 11:01 AM
MECexample.png
34 kB
28/Nov/23 9:19 PM
todo-failing.png
44 kB
16/Oct/23 7:01 PM
todo-passing.png
40 kB
16/Oct/23 7:01 PM
view-only-done.png
40 kB
16/Oct/23 7:02 PM

Discovered while testing

MDL-75572 Badges using activity completion with passing grade criteria, even when failed grade is given

Closed

duplicates

MDL-80262 Activity Completion Buttons are Incorrect for some Activities

Closed

has a non-specific relationship to

MDL-81601 Activity with only "Receive a grade" for the completion condition is being shown as "Failed" in the course index

Closed

has to be finished together with

MDL-80392 completion_info_exporter does not support new is_overall_complete() method so external systems can't retrieve the correct completion status

Closed

is a regression caused by

MDL-78744 Refactor 'activity_information' output class

Closed

is duplicated by

MDL-80435 Activity completion status remains as “To do” even all the conditions are met.

Closed

MDL-80680 External Tool Activity Completion not displayed as "Done" on course page

Closed

will help resolve

MDL-75582 Activities with passing grade and only require grade completion (not passing) are displaying the wrong status

Reopened

(2 is duplicated by, 1 will help resolve)

Assignee:: Sara Arjona (@sarjona)

Reporter:: Jun Pataleta

Peer reviewer:: Carlos Escobedo

Integrator:: Amaia Anabitarte

Tester:: Ron Carl Alfon Yu

Participants:: Amaia Anabitarte, Carlos Escobedo, CiBoT, Isabel Renedo Rouco, Jessica Gramp, Juan Leyva, Jun Pataleta, Mary Cooch, Plínio Felipe, Ron Carl Alfon Yu, Sara Arjona (@sarjona), studio-mbruce, ToBiC

Votes:: 9 Vote for this issue

Watchers:: 23 Start watching this issue

Created:: 16/Oct/23 6:59 PM

Updated:: 18/Sep/24 2:41 AM

Resolved:: 08/Dec/23 12:23 AM

Estimated:

Not Specified

Remaining:

Logged:

7h 4m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify