Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-79737

In boost theme, scrolling disabled after a side drawer closes by window resizing

Details

    • MOODLE_401_STABLE
    • MDL79737-boost-modal-drawer-scroll-bug
    • MDL79737-boost-modal-drawer-scroll-bug-4.2
    • MDL79737-boost-modal-drawer-scroll-bug-4.3
    • MDL79737-boost-modal-drawer-scroll-bug-master
    • Hide

      Scenario 1:

      1. In Moodle, navigate to a course page (one with enough content that the page is scrollable.)
      2. Shrink the window's width to less than 991 pixels (smaller than the "medium" breakpoint)
      3. Click the icon to open the drawer
      4. Note that the drawer opens in a modal. The rest of the page (behind the drawer) is grayed out and can't be scrolled.
      5. Expand the window to wider than 991 pixels (larger than the "medium" breakpoint)

      Expected result: The drawer goes from modal to normal mode. The main content of the page is no longer grayed out, and the main content is again scrollable.

      Actual result: All of the above, except that the main content is not scrollable.

      Scenario 2:

      1. In Moodle, navigate to a course page (one with enough content that the page is scrollable.)
      2. Expand the window's width to more than 991 pixels (wider than the "medium" breakpoint)
      3. Click the icon to open the drawer
      4. Note that the drawer does not open as a modal. The rest of the page is visible and scrollable as normal.
      5. Narrow the window to less than 991 pixels wide (narrower than the "medium" breakpoint)

      Expected result: The drawer turns into a modal. The main content of the page gets grayed out, and scrolling the main content is disabled.

      Actual result: The drawer does turn into a modal and the page does get grayed out, but scrolling of the main content is not disabled.

      Show
      Scenario 1: 1. In Moodle, navigate to a course page (one with enough content that the page is scrollable.) 2. Shrink the window's width to less than 991 pixels (smaller than the "medium" breakpoint) 3. Click the icon to open the drawer 4. Note that the drawer opens in a modal. The rest of the page (behind the drawer) is grayed out and can't be scrolled. 5. Expand the window to wider than 991 pixels (larger than the "medium" breakpoint) Expected result: The drawer goes from modal to normal mode. The main content of the page is no longer grayed out, and the main content is again scrollable. Actual result: All of the above, except that the main content is not scrollable. Scenario 2: 1. In Moodle, navigate to a course page (one with enough content that the page is scrollable.) 2. Expand the window's width to more than 991 pixels (wider than the "medium" breakpoint) 3. Click the icon to open the drawer 4. Note that the drawer does not open as a modal. The rest of the page is visible and scrollable as normal. 5. Narrow the window to less than 991 pixels wide (narrower than the "medium" breakpoint) Expected result: The drawer turns into a modal. The main content of the page gets grayed out, and scrolling the main content is disabled. Actual result: The drawer does turn into a modal and the page does get grayed out, but scrolling of the main content is not disabled.

    Description

      I noticed this in Moodle 4.1. In the boost theme, when you're viewing a course or other screen that has a "drawer" on the side, if the window is narrow past a certain threshold, the drawer will open as a modal. The rest of the document gets grayed out, and scrolling is disabled on it. Then when you close the modal, the document gets un-grayed and scrolling is re-enabled.

      However, if you expand the window while the drawer modal is open, the modal goes away and the document is un-grayed, but scrolling is not re-enabled.

      Similarly, if you start with the window wide, open the drawer, and narrow the window, the drawer will change into a modal but the underlying page's scrolling will not get disabled as it should.

      Attachments

        Activity

          People

            aaronw@catalyst.net.nz Aaron Wells
            aaronw@catalyst.net.nz Aaron Wells
            Meirza Meirza
            Votes:
            0 Vote for this issue
            Watchers:
            17 Start watching this issue

            Dates

              Created:
              Updated:

              Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 15 minutes
                15m

                Clockify

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.