Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-79756

Remove usage of master and slave in core/checkbox-toggleall

    • Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: Minor Minor
    • None
    • 4.4
    • JavaScript
    • MOODLE_404_STABLE
    • MDL-79756-main
    • Hide

      Choice activity

      Prerequisites
      1. A course with at least one teacher and two students.
      2. A Choice activity in a course with the following settings:
        • Has at least two options.
        • Publish results: Always show results to students.
        • Privacy of results: Publish full results, showing names and their choices.
        • "Show column for unanswered": Yes.
      Test
      1. Login as a teacher.
      2. Go to the choice activity.
      3. Below the Responses table, confirm that there is a "Select all" button.
      4. Click on it.
      5. Confirm that the checkboxes beside each participant in the responses table are checked.
      6. Confirm that its text becomes "Deselect all"
      7. Click on "Deselect all"
      8. Confirm that the checkboxes beside each participant in the responses table become unchecked.
      9. Check/uncheck the checkboxes right under each column header
      10. Confirm that the checkboxes under the same column are checked when the column header checkbox is checked.
      11. Confirm that when the column header checkbox gets unchecked, the checkboxes under the same column also get checked.
      12. Tick all of the items under a column.
      13. Confirm that the checkbox under the column header also gets checked.
      14. Untick one or more items under a column.
      15. Confirm that the checkbox under the column header also gets unchecked.
      16. Click the "Select all" button again
      17. Untick one of the items
      18. Confirm that the Deselect all" button's label becomes "Select all"
      19. Check the state of the "With selected" select box.
      20. Confirm that when no items are selected, the select box is disabled.
      21. Confirm that when at least one item is selected, the select box becomes enabled.

      Bulk user actions

      1. Repeat the testing of MDL-80548 and confirm that everything still works as expected.

      Gradebook setup

      1. Repeat the testing of MDL-65948 and confirm that everything still works as expected.

      Tags

      1. Log in as an admin
      2. Go to "Site administration > Appearance > Manage tags"
      3. Click on the "Default collection"
      4. Confirm that the "Select all" checkbox (checkbox on the table header) toggles all of the checkboxes for the entries.
      5. Confirm that deselecting a checkbox in any of the rows toggles off the tick on the "Select all" checkbox.
      6. Confirm that selecting all checkboxes in the list of entries selects toggles the tick on the "Select all" checkbox back on.

      File manager

      1. Repeat the testing for MDL-79927 and confirm that everything still works as expected.

      Database activity

      1. Create a database activity
      2. Use any preset
      3. On the Templates page, select "List view template" and add ##delcheck## to the "Repeated entry" template.
      4. Save the changes.
      5. Add at least two entries.
      6. Go to the list view
      7. You should see a checkbox on each entry
      8. Confirm that pressing "Select all" selects all checkboxes in the entries.
      9. Confirm that it changes to "Deselect all" and clicking on "Deselect all" deselect all entries.
      10. Confirm that selecting at least one entry activates the "Delete selected" button and that selecting none deactivates it.

      Feedback activity

      1. Repeat the testing for MDL-65935 and confirm that everything still works as expected.

      Forum bulk actions

      1. Check out the forum bulk actions feature introduced in MDL-66298 and confirm that the checkbox selection still works as expected in the forum summary report

      Lesson

      1. Repeat the testing for MDL-65937 and confirm that everything still works as expected.

      Quiz

      1. Repeat the testing for MDL-65938 and confirm that everything still works as expected.

      SCORM

      1. Repeat the testing for MDL-65946 and confirm that everything still works as expected.

      Question bank

      1. Repeat the testing for MDL-65994 and confirm that everything still works as expected.

      Analytics

      1. Check out MDL-62191 and confirm that the bulk selection of entries in the insights report still works as expected.

      Participation report

      1. Repeat the testing for MDL-65949 and confirm that everything still works as expected.

      Repository

      1. Check out MDL-33671 and confirm that the bulk selection of files in the private files repository still works as expected.

      Course participants page

      1. Repeat the testing for MDL-65950 and confirm that everything still works as expected.
      Show
      Choice activity Prerequisites A course with at least one teacher and two students. A Choice activity in a course with the following settings: Has at least two options. Publish results: Always show results to students. Privacy of results: Publish full results, showing names and their choices. " Show column for unanswered ": Yes. Test Login as a teacher. Go to the choice activity. Below the Responses table, confirm that there is a " Select all " button. Click on it. Confirm that the checkboxes beside each participant in the responses table are checked. Confirm that its text becomes " Deselect all " Click on "Deselect all" Confirm that the checkboxes beside each participant in the responses table become unchecked. Check/uncheck the checkboxes right under each column header Confirm that the checkboxes under the same column are checked when the column header checkbox is checked. Confirm that when the column header checkbox gets unchecked, the checkboxes under the same column also get checked. Tick all of the items under a column. Confirm that the checkbox under the column header also gets checked. Untick one or more items under a column. Confirm that the checkbox under the column header also gets unchecked. Click the " Select all " button again Untick one of the items Confirm that the Deselect all " button's label becomes "Select all" Check the state of the " With selected " select box. Confirm that when no items are selected, the select box is disabled. Confirm that when at least one item is selected, the select box becomes enabled. Bulk user actions Repeat the testing of MDL-80548 and confirm that everything still works as expected. Gradebook setup Repeat the testing of MDL-65948 and confirm that everything still works as expected. Tags Log in as an admin Go to " Site administration > Appearance > Manage tags " Click on the " Default collection " Confirm that the " Select all " checkbox (checkbox on the table header) toggles all of the checkboxes for the entries. Confirm that deselecting a checkbox in any of the rows toggles off the tick on the " Select all " checkbox. Confirm that selecting all checkboxes in the list of entries selects toggles the tick on the " Select all " checkbox back on. File manager Repeat the testing for MDL-79927 and confirm that everything still works as expected. Database activity Create a database activity Use any preset On the Templates page, select "List view template" and add ##delcheck## to the " Repeated entry " template. Save the changes. Add at least two entries. Go to the list view You should see a checkbox on each entry Confirm that pressing " Select all " selects all checkboxes in the entries. Confirm that it changes to " Deselect all " and clicking on " Deselect all " deselect all entries. Confirm that selecting at least one entry activates the " Delete selected " button and that selecting none deactivates it. Feedback activity Repeat the testing for MDL-65935 and confirm that everything still works as expected. Forum bulk actions Check out the forum bulk actions feature introduced in MDL-66298 and confirm that the checkbox selection still works as expected in the forum summary report Lesson Repeat the testing for MDL-65937 and confirm that everything still works as expected. Quiz Repeat the testing for MDL-65938 and confirm that everything still works as expected. SCORM Repeat the testing for MDL-65946 and confirm that everything still works as expected. Question bank Repeat the testing for MDL-65994 and confirm that everything still works as expected. Analytics Check out MDL-62191 and confirm that the bulk selection of entries in the insights report still works as expected. Participation report Repeat the testing for MDL-65949 and confirm that everything still works as expected. Repository Check out MDL-33671 and confirm that the bulk selection of files in the private files repository still works as expected. Course participants page Repeat the testing for MDL-65950 and confirm that everything still works as expected.
    • Hide

      Code verified against automated checks with warnings.

      Checked MDL-79756 using repository: https://github.com/junpataleta/moodle.git

      Should these errors be fixed?

      Built on: Mon 18 Nov 2024 12:30:33 PM UTC

      Show
      Code verified against automated checks with warnings. Checked MDL-79756 using repository: https://github.com/junpataleta/moodle.git main (0 errors / 2 warnings) [branch: MDL-79756-main | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/2) , gherkin (0/0) , Should these errors be fixed? Built on: Mon 18 Nov 2024 12:30:33 PM UTC

      We need better and more inclusive wordings for the checkboxes in pages that use the core/checkbox-toggleall module.

      Possible alternatives for the "master" and "slave" checkboxes:

      • "parent" and "child" checkboxes
      • "controller" and "target" checkboxes

            jpataleta Jun Pataleta
            jpataleta Jun Pataleta
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.