Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-79762

Modal forms no longer support alternative form type.

    XMLWordPrintable

Details

    • MOODLE_403_STABLE
    • MOODLE_403_STABLE
    • MDL-79762-master
    • Hide

      We need to make sure that patch does not introduce regression. Using alternative modal type for modal forms functionality is not used in core.

      Modal forms are in use at the User profile fileds configuration, which can be used for regression testing:
      1. Navigate to "Site admin" > "Users" > "User profile fields" page (user/profile/index.php)
      2. Click "Create a new profile category" - make sure that there are no browser dev console error and the modal form is shown correctly, both "Save changes" and "Cancel" buttons are present.
      3. Enter some category name and save, make sure that new category is listed and there are no errors related to modal (it got closed and console is free from errors).

      Show
      We need to make sure that patch does not introduce regression. Using alternative modal type for modal forms functionality is not used in core. Modal forms are in use at the User profile fileds configuration, which can be used for regression testing: 1. Navigate to "Site admin" > "Users" > "User profile fields" page (user/profile/index.php) 2. Click "Create a new profile category" - make sure that there are no browser dev console error and the modal form is shown correctly, both "Save changes" and "Cancel" buttons are present. 3. Enter some category name and save, make sure that new category is listed and there are no errors related to modal (it got closed and console is free from errors).
    • WP Sprint 2023-I4.0

    Description

      Following MDL-78324 it became impossible to define an alternative modal type for the modalform, SaveCancelModal is hardcoded.

      There should be a flexibility to define an alternative type.

      Attachments

        Issue Links

          Activity

            People

              kabalin Ruslan Kabalin
              kabalin Ruslan Kabalin
              Marina Glancy Marina Glancy
              Paul Holden Paul Holden
              Kim Jared Lucas Kim Jared Lucas
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 7 hours, 10 minutes
                  7h 10m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.