We need to make sure that patch does not introduce regression. Using alternative modal type for modal forms functionality is not used in core.
Modal forms are in use at the User profile fileds configuration, which can be used for regression testing:
1. Navigate to "Site admin" > "Users" > "User profile fields" page (user/profile/index.php)
2. Click "Create a new profile category" - make sure that there are no browser dev console error and the modal form is shown correctly, both "Save changes" and "Cancel" buttons are present.
3. Enter some category name and save, make sure that new category is listed and there are no errors related to modal (it got closed and console is free from errors).
We need to make sure that patch does not introduce regression. Using alternative modal type for modal forms functionality is not used in core.
Modal forms are in use at the User profile fileds configuration, which can be used for regression testing:
1. Navigate to "Site admin" > "Users" > "User profile fields" page (user/profile/index.php)
2. Click "Create a new profile category" - make sure that there are no browser dev console error and the modal form is shown correctly, both "Save changes" and "Cancel" buttons are present.
3. Enter some category name and save, make sure that new category is listed and there are no errors related to modal (it got closed and console is free from errors).
WP Sprint 2023-I4.0
Following MDL-78324 it became impossible to define an alternative modal type for the modalform, SaveCancelModal is hardcoded.
There should be a flexibility to define an alternative type.