Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Critical
Fix Version/s: 4.4.6, 4.5.2
Affects Version/s: 4.1.6, 4.4.5
Component/s: Assignment
Labels:
- CatalystIT
- ci
- partner
- release_notes

Affected Branches:
MOODLE_401_STABLE, MOODLE_404_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/jonof/moodle.git
Pull 4.4 Branch:
~~MDL-79819~~_404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...jonof:moodle:MDL-79819_404
Pull 4.5 Branch:
~~MDL-79819~~_405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...jonof:moodle:MDL-79819_405
Pull Main Branch:
~~MDL-79819~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...jonof:moodle:MDL-79819
Testing Instructions:
Hide

PHPUnit tests verify the behaviour of the jpeg-to-pdf conversion where the fault occurs.

As a manual test:

Source a HEIC-format image and rename it to have a .jpg extension (e.g. use the fixture file I have included for the PHPUnit test).

Upload the file into a File submission.

Run adhoc cron and observe the assignfeedback_editpdf\task\convert_submission task completes without error. If you have cron debugging enabled you would see the problematic conversion reported, but also that "The document has been successfully converted".
Show
PHPUnit tests verify the behaviour of the jpeg-to-pdf conversion where the fault occurs. As a manual test: Source a HEIC-format image and rename it to have a .jpg extension (e.g. use the fixture file I have included for the PHPUnit test). Upload the file into a File submission. Run adhoc cron and observe the assignfeedback_editpdf\task\convert_submission task completes without error. If you have cron debugging enabled you would see the problematic conversion reported, but also that "The document has been successfully converted".
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-79819~~ using repository: https://github.com/jonof/moodle.git

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-79819_404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-79819_405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-79819 | CI Job]

_{More information about this report}

Built on: Tue 29 Oct 2024 10:18:23 AM UTC
Show
Code verified against automated checks. Checked MDL-79819 using repository: https://github.com/jonof/moodle.git MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-79819_404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-79819_405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-79819 | CI Job ] More information about this report Built on: Tue 29 Oct 2024 10:18:23 AM UTC
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-79819~~_404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17173/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58463/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58464/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-79819~~_405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17174/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58465/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58466/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-79819~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17175/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58467/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58468/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58469/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58470/ App tests (stable app version) --> unrelated, reported to apps team.

Built on: Tue Oct 29 12:35:04 PM UTC 2024
Show
Launching automatic jobs for branch MDL-79819 _404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17173/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58463/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58464/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-79819 _405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17174/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58465/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58466/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-79819 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17175/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58467/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58468/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58469/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58470/ App tests (stable app version) --> unrelated, reported to apps team. Built on: Tue Oct 29 12:35:04 PM UTC 2024

After upgrading my Moodle from version 3.9 to 4.1.6, I've encountered a concerning issue. The system is generating approximately 5GB of data within just 1-2 hours every day for the past ten days. In the cron log, I've noticed errors that read:

'adhoc task failed: assignfeedback_editpdf\task\convert_submission: tcpdf error: [image] unable to get the size of the image'

I have made sure that the path to the Ghostscript library is correctly set up (path to 'pdftoppm' library is empty.

Moodle release: 4.1.6+ (Build: 20231013)
PDF producer: TCPDF 6.5.0

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

Zrzut ekranu 2023-10-20 o 09.56.14.png
86 kB
23/Oct/23 6:50 PM

Assignee:: Jonathon Fowler

Reporter:: Daniel Marzec

Peer reviewer:: Kevin Percy

Integrator:: Glyn (Mathew) May

Tester:: CiBoT

Participants:: Behan Webster, CiBoT, Daniel Marzec, Eric Phetteplace, Glyn (Mathew) May, Jonathon Fowler, Kevin Percy, Michelle Melton, Peter Diedrichs, Sara Arjona (@sarjona), Shuhei Oishi

Votes:: 14 Vote for this issue

Watchers:: 26 Start watching this issue

Created:: 23/Oct/23 6:13 PM

Updated:: 04/Feb/25 1:51 PM

Resolved:: 31/Jan/25 10:48 AM

Estimated:

Not Specified

Remaining:

Logged:

4h 9m

Details

Description

Attachments

Attachments

Activity

People

Dates

Time Tracking

Clockify