Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-79820

Better explain to developers what was changed in modals in 4.3

Details

    • Bug
    • Resolution: Unresolved
    • Minor
    • None
    • 4.3
    • JavaScript
    • None

    Description

      In Moodle 4.3 modal factory was deprecated and it was expected that all new classes extending Modal must declare TYPE and TEMPLATE . However the base class already declares them, which means that all the places where Moodle complains about missing declarations are unreachable - example 1, example 2

      Moreover, the type for the actual class Modal is defined as lowercase 'default' here and uppercase 'DEFAULT' here

      We have already reported a regression in modal forms, see MDL-79762 . As I commented there, it would be nice to provide fallbacks/warning messages to explain to developers what they need to change.

      Before we made all the necessary changes in Workplace code, I was trying to come up with a core patch that would show the error messages and explain developers what exactly they need to do to upgrade custom modal types to 4.3

      Attachments

        Issue Links

          Activity

            People

              marina Marina Glancy
              marina Marina Glancy
              Andrew Lyons Andrew Lyons
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 10 minutes
                  2h 10m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.