In Moodle 4.3 modal factory was deprecated and it was expected that all new classes extending Modal must declare TYPE and TEMPLATE . However the base class already declares them, which means that all the places where Moodle complains about missing declarations are unreachable - example 1, example 2

Moreover, the type for the actual class Modal is defined as lowercase 'default' here and uppercase 'DEFAULT' here

We have already reported a regression in modal forms, see MDL-79762 . As I commented there, it would be nice to provide fallbacks/warning messages to explain to developers what they need to change.

Before we made all the necessary changes in Workplace code, I was trying to come up with a core patch that would show the error messages and explain developers what exactly they need to do to upgrade custom modal types to 4.3