Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-79827

Tiny editor link plugin doesn't correctly observe whether files can be uploaded

XMLWordPrintable

    • MOODLE_402_STABLE
    • MOODLE_401_STABLE, MOODLE_402_STABLE, MOODLE_403_STABLE
    • MDL-79827-401
    • MDL-79827-403
    • Hide
      1. Log in as admin
      2. Create a user
      3. Create a course
      4. Enrol user as student
      5. Create assignment
      6. Navigate to course grades
      7. Turn editing on
      8. Press Edit grade for the user/assignment
      9. Tick Overridden
      10. In Feedback editor, press Insert > Link
      11. Confirm there is no Browse repositories button in the dialog
      12. Navigate to Profile from user menu
      13. Press Edit profile
      14. In Description editor, press Insert > Link
      15. Confirm there is a Browse repositories button in the dialog
      16. Confirm you can use Browse repositories to upload a file
      17. Confirm the link to uploaded file appears in the editor
      Show
      Log in as admin Create a user Create a course Enrol user as student Create assignment Navigate to course grades Turn editing on Press Edit grade for the user/assignment Tick Overridden In Feedback editor, press Insert > Link Confirm there is no Browse repositories button in the dialog Navigate to Profile from user menu Press Edit profile In Description editor, press Insert > Link Confirm there is a Browse repositories button in the dialog Confirm you can use Browse repositories to upload a file Confirm the link to uploaded file appears in the editor
    • 1
    • Team Hedgehog 2023 Sprint 4.1

      See the original report from MDL-79547 (reporting separately here, because that issue is actually requesting the ability to add files to grade feedback - which is currently explicitly disabled)

      The bug here is that the editor isn't observing whether it's possible to add files to the editor, so when you click the Browse repositories button in the Create link dialog then nothing appears to happen, other than the following error in the browser console:

      Uncaught (in promise) Unknown filetype link

      For reference, here is the same implementation in the Atto editor: https://github.com/moodle/moodle/blob/d76e211be6ae65fe3982ad97f3fe5c879a7b2daa/lib/editor/atto/yui/src/editor/js/filepicker.js#L53-L55

        1. (1) 11 Passed -- (Master)MDL-79827.png
          (1) 11 Passed -- (Master)MDL-79827.png
          31 kB
        2. (1) 15 Passed -- (Master)MDL-79827.png
          (1) 15 Passed -- (Master)MDL-79827.png
          29 kB
        3. (1) 16 Passed -- (Master)MDL-79827.png
          (1) 16 Passed -- (Master)MDL-79827.png
          96 kB
        4. (1) 17 Passed -- (Master)MDL-79827.png
          (1) 17 Passed -- (Master)MDL-79827.png
          53 kB

            pholden Paul Holden
            pholden Paul Holden
            Meirza Meirza
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            0 Vote for this issue
            Watchers:
            10 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 57 minutes
                57m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.