-
Bug
-
Resolution: Fixed
-
Minor
-
4.3
-
MOODLE_403_STABLE
-
MOODLE_403_STABLE
-
MDL-79840-403 -
- Manually edit contentbank/contenttype/h5p/classes/contenttype.php:
- public function get_icon(\core_contentbank\content $content): string {+ public function __get_icon(\core_contentbank\content $content): string {- This simulates a contenttype plugin not overriding the base get_icon implementation
- Log in as admin
- Manually navigate to <WWWROOT>/contentbank/index.php
- Press Upload
- Upload greeting-card.h5p
and save changes - Press Exit
- Confirm presence of "unknown" (question mark) icon next to the greeting-card content you just uploaded
Manually edit contentbank/contenttype/h5p/classes/contenttype.php : - public function get_icon(\core_contentbank\content $content): string { + public function __get_icon(\core_contentbank\content $content): string { This simulates a contenttype plugin not overriding the base get_icon implementation Log in as admin Manually navigate to <WWWROOT>/contentbank/index.php Press Upload Upload greeting-card.h5p and save changes Press Exit Confirm presence of "unknown" (question mark) icon next to the greeting-card content you just uploaded - Manually edit contentbank/contenttype/h5p/classes/contenttype.php:
This is the same problem as reported previously in MDL-79534 (caused by removal of size specific icons originally in MDL-78884)
- The base implementation of get_icon() refers to invalid image
- The "testable" contenttype also refers to invalid image
In the second case, remove that implementation from the "testable" class because it's only actually used to be tested. We are testing a test method, which is silly 
The testcase can just assert the base implementation
According to the following naive grep, these are the only remaining cases referring to images using size-specific version:
$ git grep "image_url(.*[0-9]'" -- '*.php'
|
