Loading...

XML

Word

Printable

Affected Branches:
MOODLE_401_STABLE, MOODLE_402_STABLE, MOODLE_403_STABLE
Fixed Branches:
MOODLE_401_STABLE, MOODLE_402_STABLE, MOODLE_403_STABLE
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull 4.1 Branch:
~~MDL-79856~~-401
Pull 4.1 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_401_STABLE...paulholden:MDL-79856-401
Pull 4.3 Branch:
~~MDL-79856~~-403
Pull 4.3 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_403_STABLE...paulholden:MDL-79856-403
Pull Main Branch:
~~MDL-79856~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/master...paulholden:MDL-79856
Testing Instructions:
Hide

Log in as admin

Navigate to Users > Permissions > Define roles in site administration

Press Delete for the Teacher role

Confirm you are prompted with the following text:

Are you sure that you want to delete role "Teacher (editingteacher)"?
Show
Log in as admin Navigate to Users > Permissions > Define roles in site administration Press Delete for the Teacher role Confirm you are prompted with the following text: Are you sure that you want to delete role "Teacher (editingteacher)"?

When deleting a role from the Manage roles administration interface, the confirmation message looks like the following:

Are you sure that you want to delete role " (editingteacher)"?

Because the wrong role property is being passed to the language string (it should be using localname)

Found while looking at ~~MDL-79781~~

Discovered while testing

MDL-79781 Error in Courses Pending approval when the default role is deleted

has been marked as being related by

MDL-79929 PR only: MDL-79856 - Role deletion confirmation contains missing role name

Estimated:

Remaining:

Logged:

23m