Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-80037

Theme selector does not indicate when $CFG->theme is defined in config.php

XMLWordPrintable

    • MOODLE_403_STABLE
    • MOODLE_403_STABLE
    • MDL-80037-403
    • MDL-80037-master
    • Hide

      Test

      1. Set "$CFG->theme = 'classic';" in config.php
      2. Log in as an admin
      3. Go to Site administration > Appearance > Theme selector
      4. Confirm that the page indicates that the theme is defined in config.php
      5. Confirm that the selected theme has an indication that it is defined in config.php
      6. Confirm that the "Select theme" / "Use theme" button is not displayed for the other themes.
      Preview modal (master only)
      1. Click the preview theme icon button on a theme card for the currently selected theme.
      2. Confirm that the modal dialogue indicates that the theme is defined in config.php.
      3. Close the modal dialogue and click the preview theme button of another theme.
      4. Confirm that the "Select theme" button is not shown.

      Regression test

      1. Remove or comment out $CFG->theme in config.php.
      2. Confirm that there is no indication that the theme is defined in config.php
      3. Confirm that you can change the theme by pressing the "Select theme" or "Use theme" button.
      4. (master only)
      Preview modal (master only)
      1. Click the preview theme icon button on a theme card for the currently selected theme.
      2. Confirm that the modal dialogue does not indicate that the theme is defined in config.php.
      3. Close the modal dialogue and click the preview theme button of another theme.
      4. Confirm that the "Select theme" button is shown.
      5. Confirm that clicking it applies the theme to the site.
      Show
      Test Set " $CFG->theme = 'classic'; " in config.php Log in as an admin Go to Site administration > Appearance > Theme selector Confirm that the page indicates that the theme is defined in config.php Confirm that the selected theme has an indication that it is defined in config.php Confirm that the "Select theme" / "Use theme" button is not displayed for the other themes. Preview modal (master only) Click the preview theme icon button on a theme card for the currently selected theme. Confirm that the modal dialogue indicates that the theme is defined in config.php. Close the modal dialogue and click the preview theme button of another theme. Confirm that the "Select theme" button is not shown. Regression test Remove or comment out $CFG->theme in config.php. Confirm that there is no indication that the theme is defined in config.php Confirm that you can change the theme by pressing the "Select theme" or "Use theme" button. (master only) Preview modal (master only) Click the preview theme icon button on a theme card for the currently selected theme. Confirm that the modal dialogue does not indicate that the theme is defined in config.php. Close the modal dialogue and click the preview theme button of another theme. Confirm that the "Select theme" button is shown. Confirm that clicking it applies the theme to the site.

      Being an external admin page, the theme selector page does not indicate when it is defined in config.php.

      This may cause confusion for admins (especially for sites with multiple admins) when trying to change themes but the selected theme does not get applied.

      To reproduce:

      1. Set "$CFG->theme = 'classic';" in config.php
      2. Log in as an admin
      3. Go to Site administration > Appearance > Theme selector
      4. Expected:
        • The page should indicate that the theme is defined in config.php
        • The "Use theme" buttons should be hidden or disabled.
      5. Actual:
        • There's no indication that the theme is defined in config.php
        • "Use theme" can be pressed to select another theme but nothing happens.

      Notes:
      This affects 4.3 and up as a result of changes to theme/index.php in MDL-77793

            jpataleta Jun Pataleta
            jpataleta Jun Pataleta
            Paul Holden Paul Holden
            Ferran Recio Ferran Recio
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            0 Vote for this issue
            Watchers:
            13 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 5 hours, 5 minutes
                5h 5m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.