Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-80092

Incorrect logic about not showing activity navigation

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: Minor Minor
    • None
    • 4.3
    • Course, Themes
    • MOODLE_403_STABLE

      There is some inconsistency IMO about when the activity navigation shows up (the left/right buttons at the bottom of an activity)

      The code relevant here is:

      https://github.com/moodle/moodle/blob/d71532a7e03974aec22f018e3c9535a27bcbd56f/lib/outputrenderers.php#L1024-L1029

      • Topics: uses_course_index() == true, pagelayout = 'incourse' -> returns nothing
      • Social: uses_course_index() == false, pagelayout = 'incourse' -> return links

      This seems really strange, since I would expect regardless if a page uses a course index, that it shows the activity navigation links.

      Is there any reason for this check ?

            Unassigned Unassigned
            matthewhilton Matthew Hilton
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.