Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-80102

overallcompletion ignores possible completion states

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Duplicate
    • Icon: Minor Minor
    • None
    • 4.1.4
    • Course
    • MOODLE_401_STABLE

      In https://github.com/moodle/moodle/blob/master/course/classes/output/activity_information.php#L152-L154 we have (lines 140 - 143)

      // Overall completion states.
      		 
      $overallcompletion=$this->cmcompletion->get_overall_completion();
      		 
      $data->overallcomplete=$overallcompletion==COMPLETION_COMPLETE;
      		 
      $data->overallincomplete=$overallcompletion==COMPLETION_INCOMPLETE;

       

      However, overall completion state can also be COMPLETION_COMPLETE_PASS and COMPLETION_COMPLETE_FAIL

      $data->overallcomplete will be set to false in these cases. Which is incorrect imo.

            Unassigned Unassigned
            michielb Michiel Boerman
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.