Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-80303

Clean old SCSS in course.scss file

XMLWordPrintable

    • MOODLE_404_STABLE, MOODLE_500_STABLE
    • MOODLE_500_STABLE
    • MDL-80303-main
    • Hide

      Setup

      1. Login as administrator
      2. Create a new Course with "Custom sections" format
        1.  Add some activities and section descriptions (Use also lists in the text)
        2. Hide some activities and sections
        3. Add completion to some activities
        4. Add restriction access to some sections and activities
        5. Highlight one section
      3. Create a new Course with "Social" format
        1. Add some posts to the Social forum
      4. On the Home page, add a description and some activities to the frontpage section

      The main goal of the test is detect any UI glitch in the course related pages.

      Test on Boost

      1. Go to Home page
      2. Confirm the frontpage section is correctly displayed
      3. Go to the "Custom sections" course
      4. Enable Edit mode
      5. Confirm the course page is correctly displayed
      6. Disable Edit mode
      7. Confirm the course page is correctly displayed
      8. Go to course Settings page
      9. In Course format > Course layout set "Course one section per page"
      10. Confirm the course page is correctly displayed
      11. On any section press the action menu and click on View
      12. Confirm the section page is correctly displayed
      13. Go to the "Social" course
      14. Confirm the course page is correctly displayed

      Test on Classic

      1. Go to Home page
      2. Confirm the frontpage section is correctly displayed
      3. Go to the "Custom sections" course
      4. Enable Edit mode
      5. Confirm the course page is correctly displayed
      6. Disable Edit mode
      7. Confirm the course page is correctly displayed
      8. Go to course Settings page
      9. In Course format > Course layout set "Course one section per page"
      10. Confirm the course page is correctly displayed
      11. On any section press the action menu and click on View
      12. Confirm the section page is correctly displayed
      13. Go to the "Social" course
      14. Confirm the course page is correctly displayed
      Show
      Setup Login as administrator Create a new Course with "Custom sections" format  Add some activities and section descriptions (Use also lists in the text) Hide some activities and sections Add completion to some activities Add restriction access to some sections and activities Highlight one section Create a new Course with "Social" format Add some posts to the Social forum On the Home page, add a description and some activities to the frontpage section The main goal of the test is detect any UI glitch in the course related pages. Test on Boost Go to Home page Confirm the frontpage section is correctly displayed Go to the "Custom sections" course Enable Edit mode Confirm the course page is correctly displayed Disable Edit mode Confirm the course page is correctly displayed Go to course Settings page In Course format > Course layout set "Course one section per page" Confirm the course page is correctly displayed On any section press the action menu and click on View Confirm the section page is correctly displayed Go to the "Social" course Confirm the course page is correctly displayed Test on Classic Go to Home page Confirm the frontpage section is correctly displayed Go to the "Custom sections" course Enable Edit mode Confirm the course page is correctly displayed Disable Edit mode Confirm the course page is correctly displayed Go to course Settings page In Course format > Course layout set "Course one section per page" Confirm the course page is correctly displayed On any section press the action menu and click on View Confirm the section page is correctly displayed Go to the "Social" course Confirm the course page is correctly displayed
    • Hide

      Code verified against automated checks with warnings.

      Checked MDL-80303 using repository: https://github.com/roland04/moodle.git

      Should these errors be fixed?

      Built on: Tue 03 Dec 2024 02:31:01 PM UTC

      Show
      Code verified against automated checks with warnings. Checked MDL-80303 using repository: https://github.com/roland04/moodle.git main (0 errors / 2 warnings) [branch: MDL-80303-main | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/2) , gherkin (0/0) , Should these errors be fixed? Built on: Tue 03 Dec 2024 02:31:01 PM UTC
    • Show
      Launching automatic jobs for branch MDL-80303 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17288/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58908/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58909/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58910/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58911/ App tests (stable app version) Built on: Thu Nov 7 16:31:42 UTC 2024
    • 3
    • HQ 2024 Sprint I4.1 Moppies

      After MDL-72656 deprecation, many renderers and templates were changed or removed, so many lines of SCSS code could be potentially removed.

      There is a comment in course.scss file noting it:

      // These are the new styles for the renewed course UI in isssue MDL-71691
      // once the old course renderers are removed in MDL-72656, all css related
      // to activities and sections above this commend needs to be reviewed an
      // possibly removed. 
      

        1. (1) 10 Passed -- (Main)MDL-80303.png
          (1) 10 Passed -- (Main)MDL-80303.png
          171 kB
        2. (1) 12 Passed -- (Main)MDL-80303.png
          (1) 12 Passed -- (Main)MDL-80303.png
          129 kB
        3. (1) 14 Passed -- (Main)MDL-80303.png
          (1) 14 Passed -- (Main)MDL-80303.png
          148 kB
        4. (1) 2 Passed -- (Main)MDL-80303.png
          (1) 2 Passed -- (Main)MDL-80303.png
          60 kB
        5. (1) 5 Passed -- (Main)MDL-80303.png
          (1) 5 Passed -- (Main)MDL-80303.png
          178 kB
        6. (1) 7 Passed -- (Main)MDL-80303.png
          (1) 7 Passed -- (Main)MDL-80303.png
          176 kB
        7. (2) 10 Passed -- (Main)MDL-80303.png
          (2) 10 Passed -- (Main)MDL-80303.png
          199 kB
        8. (2) 12 Passed -- (Main)MDL-80303.png
          (2) 12 Passed -- (Main)MDL-80303.png
          158 kB
        9. (2) 14 Passed -- (Main)MDL-80303.png
          (2) 14 Passed -- (Main)MDL-80303.png
          195 kB
        10. (2) 2 Passed -- (Main)MDL-80303.png
          (2) 2 Passed -- (Main)MDL-80303.png
          131 kB
        11. (2) 5 Passed -- (Main)MDL-80303.png
          (2) 5 Passed -- (Main)MDL-80303.png
          210 kB
        12. (2) 7 Passed -- (Main)MDL-80303.png
          (2) 7 Passed -- (Main)MDL-80303.png
          200 kB
        13. screenshot-1.png
          screenshot-1.png
          91 kB
        14. screenshot-10.png
          screenshot-10.png
          118 kB
        15. screenshot-11.png
          screenshot-11.png
          136 kB
        16. screenshot-12.png
          screenshot-12.png
          125 kB
        17. screenshot-2.png
          screenshot-2.png
          84 kB
        18. screenshot-3.png
          screenshot-3.png
          111 kB
        19. screenshot-4.png
          screenshot-4.png
          108 kB
        20. screenshot-5.png
          screenshot-5.png
          82 kB
        21. screenshot-6.png
          screenshot-6.png
          121 kB
        22. screenshot-7.png
          screenshot-7.png
          167 kB
        23. screenshot-8.png
          screenshot-8.png
          125 kB
        24. screenshot-9.png
          screenshot-9.png
          133 kB

            mikelmartíncorrales Mikel Martín Corrales
            mikelmartíncorrales Mikel Martín Corrales
            Ferran Recio Ferran Recio
            Amaia Anabitarte Amaia Anabitarte
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            0 Vote for this issue
            Watchers:
            12 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 week, 1 day, 3 hours, 3 minutes
                1w 1d 3h 3m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.