-
Bug
-
Resolution: Fixed
-
Minor
-
4.1.6, 4.2.3, 4.3
-
MOODLE_401_STABLE, MOODLE_402_STABLE, MOODLE_403_STABLE
-
MOODLE_402_STABLE, MOODLE_403_STABLE
-
MDL-80323-402 -
MDL-80323-403 -
Preparation
- Open a terminal and go to your Moodle instance's root folder.
- Download 80323.diff
and apply the test patch (to ensure failure):
$ git apply /path/to/80323.diff
Test
- Log in as admin
- Navigate to Site administration > Server > System paths and fill 'Path to PHP CLI' path (probably /usr/bin/php, but that might be different in your server)
- Navigate to Server > Tasks > Scheduled tasks in site administration
- Press Run now for the Download available H5P content types from h5p.org task
- Confirm you see the following:
Scheduled task failed: Download available H5P content types from h5p.org (core\task\h5p_get_content_types_task),Invalid response value detected (No information could be obtained on the H5P content types available. H5P repository connection failure) - Navigate to Server > Tasks > Task logs in site administration
- Confirm the latest Download available H5P content types from h5p.org task run result is Fail
Preparation Open a terminal and go to your Moodle instance's root folder. Download 80323.diff and apply the test patch (to ensure failure): $ git apply /path/to/80323.diff Test Log in as admin Navigate to Site administration > Server > System paths and fill 'Path to PHP CLI' path (probably /usr/bin/php, but that might be different in your server) Navigate to Server > Tasks > Scheduled tasks in site administration Press Run now for the Download available H5P content types from h5p.org task Confirm you see the following: Scheduled task failed: Download available H5P content types from h5p.org (core\task\h5p_get_content_types_task),Invalid response value detected (No information could be obtained on the H5P content types available. H5P repository connection failure) Navigate to Server > Tasks > Task logs in site administration Confirm the latest Download available H5P content types from h5p.org task run result is Fail
When the task "Download available H5P content types from h5p.org" fails it just produces this trace:
No information could be obtained on the H5P content types available. H5P repository connection failure
But the task is still counted as succeeded. Thus nobody notices it failed and it won't try again until a month later.
The expected behavior would be for the task to throw an exception in this case.
To emulate this change the URL endpoint for H5P content types in h5p/h5plib/v124/joubel/core/h5p.classes.php#L2063.
