Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-80324

Inconsistent parameter names in admin/webservice

XMLWordPrintable

    • MOODLE_401_STABLE, MOODLE_402_STABLE, MOODLE_403_STABLE
    • MOODLE_402_STABLE, MOODLE_403_STABLE
    • MDL-80324-403
    • Hide
      1. Log in as admin
      2. Navigate to Server > Web services > External services in site administration
      3. Under Custom services press Add
        • Name: Something
        • Authorised users only: Yes
      4. Navigate back to External services
      5. Press Authorised users for your new "Something" service
      6. Select a user and press Add
      7. Under Change settings for the authorised users press on your chosen user
      8. Press Purge all caches
      9. Confirm the page reloads the same screen
      10. Press Cancel in the form
      11. Confirm you are now back on the Select authorised users page
      Show
      Log in as admin Navigate to Server > Web services > External services in site administration Under Custom services press Add Name: Something Authorised users only: Yes Navigate back to External services Press Authorised users for your new "Something" service Select a user and press Add Under Change settings for the authorised users press on your chosen user Press Purge all caches Confirm the page reloads the same screen Press Cancel in the form Confirm you are now back on the Select authorised users page

      Hey there!

      I've found out that in /admin/webservice/service_user_settings.php is an inconsistent naming of the service id parameter - function required_param() uses name "serviceid", but while setting the page url "id" is used instead. This breaks navigation, language choosing etc.

      The fix should be easy, although I'm not sure which param name to preserve, as it seems the naming is not united. Any thoughts?

      As this is a simple changing of strings, it would be possible to get this fixed before the bugfix release next week, which I think would be great.

      Cheers!

      Jarý Miroslav
      CTU FEE in Prague

        1. MDL-80324.png
          MDL-80324.png
          248 kB

            pholden Paul Holden
            jarymiro Miroslav Jarý
            Stevani Andolo Stevani Andolo
            Ilya Tregubov Ilya Tregubov
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            0 Vote for this issue
            Watchers:
            14 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 10 minutes
                1h 10m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.