Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-80333

New login notification task always queued even when feature is disabled

    XMLWordPrintable

Details

    • MOODLE_400_STABLE, MOODLE_401_STABLE, MOODLE_402_STABLE, MOODLE_403_STABLE
    • MOODLE_402_STABLE, MOODLE_403_STABLE
    • MDL-80333_402
    • MDL-80333_403
    • MDL-80333_master
    • Hide

      First Scenario

      1. Login with Administrator
      2. Go to Site Administration --> General --> Notification settings
      3. Disable only New login notifications system preference.
      4. Then login with any new or existing user from a new IP or incognito mode 
      5. Confirm send_login_notifications adhoc task is not added to the adhoc task queue for current logged in user

       

      Second Scenario

      1. Login with Administrator
      2. Keep the notification preferences for new login enabled
      3. Then login with any new or existing user from a new IP or incognito mode
      4. Confirm send_login_notifications adhoc task is added to the adhoc task queue for current logged in user.
      5. Run cron and confirm user receive new login email & popup notification.
      6. Go to Profile --> Preferences --> Notification preferences.
      7. Disable New login notifications for all message processors(email, web, mobile).
      8. Then login with same user from a new IP or incognito mode
      9. Confirm send_login_notifications adhoc task is not added to the adhoc task queue for current logged in user.

      Third Scenario

      1. Login with administrator.
      2. Go to Site Administration --> General --> Notification preferences.
      3. Disable all Notification plugins (web, email, mobile) (Refer following screenshot)
      4. Keep New login notifications enabled at site level
      5. Then login with any new or existing user from a new IP or incognito mode
      6. Confirm send_login_notifications adhoc task is not added to the adhoc task queue for current logged in user.

      Fourth Scenario

      1. Login with administrator.
      2. Go to Site Administration --> General --> Notification preferences.
      3. Keep New login notifications enabled at site level and disable it for all message processors (web, email, mobile)(Refer following screenshot)
      4. Then login with any new or existing user from a new IP or incognito mode
      5. Confirm send_login_notifications adhoc task is not added to the adhoc task queue for current logged in user.
      Show
      First Scenario Login with Administrator Go to Site Administration --> General --> Notification settings Disable only New login notifications system preference. Then login with any new or existing user from a new IP or incognito mode  Confirm send_login_notifications adhoc task is not added to the adhoc task queue for current logged in user   Second Scenario Login with Administrator Keep the notification preferences for new login enabled Then login with any new or existing user from a new IP or incognito mode Confirm send_login_notifications adhoc task is added to the adhoc task queue for current logged in user. Run cron and confirm user receive new login email & popup notification. Go to Profile --> Preferences --> Notification preferences. Disable New login notifications for all message processors(email, web, mobile). Then login with same user from a new IP or incognito mode Confirm   send_login_notifications adhoc task is not added to the adhoc task queue for current logged in user. Third Scenario Login with administrator. Go to Site Administration --> General --> Notification preferences. Disable all Notification plugins (web, email, mobile) (Refer following screenshot) Keep New login notifications enabled at site level Then login with any new or existing user from a new IP or incognito mode Confirm send_login_notifications adhoc task is not added to the adhoc task queue for current logged in user. Fourth Scenario Login with administrator. Go to Site Administration --> General --> Notification preferences. Keep New login notifications enabled at site level and disable it for all message processors (web, email, mobile)(Refer following screenshot) Then login with any new or existing user from a new IP or incognito mode Co nfirm send_login_notifications adhoc task is not added to the adhoc task queue for current logged in user.

    Description

      Hi,

      I have detected that whether the new login notification is enabled or disabled, the system always adds a new adhoc task to the queue and it always ends in success, reporting that it has sent the email.

      Actually I have detected two cases, in both cases the task is added to the queue, but the output is different:

      1. Notification active at site level but disabled by default and unlocked. The task is always queued, runs, ends as success and the log says:
          Sending login notification to <username>
          Notification successfully sent
      however, no email is sent. The log is confusing as it says a notification has been sent and it hasn't. Also, I understand that the task should not have been queued in the first place (for users who do not have it active in their profile either).

      2. Notification disabled at site level completely. The task is always queued, runs as success and the log says:
          Sending login notification to <username>
          Failed to send notification
      In this case no email is sent either. The output is also confusing as the task is listed as success and then its log says failure. In any case, I understand that the task should not have been queued either if the feature is disabled.

      Regards

      Attachments

        Issue Links

          Activity

            People

              santoshnagargoje Santosh Nagargoje
              jmabreu Miguel_
              Dinesh Dinesh
              Ilya Tregubov Ilya Tregubov
              Ron Carl Alfon Yu Ron Carl Alfon Yu
              Votes:
              6 Vote for this issue
              Watchers:
              16 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 47 minutes
                  2h 47m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.