Loading...

XML

Word

Printable

Affected Branches:
MOODLE_401_STABLE, MOODLE_402_STABLE, MOODLE_403_STABLE
Fixed Branches:
MOODLE_402_STABLE, MOODLE_403_STABLE
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull 4.3 Branch:
~~MDL-80338~~-403
Pull 4.3 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_403_STABLE...paulholden:MDL-80338-403
Pull Main Branch:
~~MDL-80338~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-80338
Testing Instructions:
Hide

Log in as admin

Create a course

Add a URL activity

External URL:

http://www.youtube.com/watch?v=Bea_2ANKJ5o#John Lequizamo - "Quotes" Music Video (The Electric Company)

Display: Embed

Press Save and display

Confirm the embedded Youtube video plays
Show
Log in as admin Create a course Add a URL activity External URL: http://www.youtube.com/watch?v=Bea_2ANKJ5o#John Lequizamo - "Quotes" Music Video (The Electric Company) Display: Embed Press Save and display Confirm the embedded Youtube video plays

The URL resource is not able to render/play embedded youtube videos when the video title has quotation marks.

Replication:

Create a course.
Turn edit mode to On.
Add a URL resource
Use the following:
- Name: Video from youtube
- External URL: http://www.youtube.com/watch?v=Bea_2ANKJ5o#John Lequizamo - "Quotes" Music Video (The Electric Company)
- Appearance / Display: Embed
Save and display.

RESULT: If you click the play icon, the video does not play.

caused a regression

MDL-81313 Revert 80338, which overzealously applies encoding to URL fragments

MDL-81316 moodle_url does not produce RFC 3986 compliant URL fragments (anchors)

has been marked as being related by

MDL-81311 LTI 1.3 Target URL fragment identifiers double-encode

Participants:: CiBoT, Glyn (Mathew) May, Huong Nguyen, Jake Dallimore, Joshua Ebarvia, Mihail Geshoski, Paul Holden, Ron Carl Alfon Yu

Estimated:

Remaining:

Logged:

1h 41m