Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-80357

Single-line comment on the last row of Raw SCSS theme setting breaks theme functionality

XMLWordPrintable

    • MOODLE_402_STABLE, MOODLE_403_STABLE
    • MOODLE_402_STABLE, MOODLE_403_STABLE
    • MDL-80357_403_STABLE
    • MDL-80357_main
    • Hide

      Add an extra empty line in the Raw SCSS setting after the single-line comment.

      [...]
      // Single line comment
      
      

      Show
      Add an extra empty line in the Raw SCSS setting after the single-line comment. [...] // Single line comment
    • Hide
      1. As admin navigate to Site administration -> Appearance -> Themes -> Boost
      2. Set 'backgroundimage' or 'loginbackgroundimage' and save.
      3. Refresh page or visit the login page.
        • CONFIRM that background image is being displayed.
      4. As admin navigate to Site administration -> Appearance -> Themes -> Boost -> Advanced settings
      5. Set 'Raw SCSS' setting as a comment i.e "// Comment" and save.
      6. Refresh the page or visit the login page.
        • CONFIRM that the background image is still present.
      Show
      As admin navigate to Site administration -> Appearance -> Themes -> Boost Set 'backgroundimage' or 'loginbackgroundimage' and save. Refresh page or visit the login page. CONFIRM that background image is being displayed. As admin navigate to Site administration -> Appearance -> Themes -> Boost -> Advanced settings Set 'Raw SCSS' setting as a comment i.e "// Comment" and save. Refresh the page or visit the login page. CONFIRM that the background image is still present.

      Upon entering a single-line comment "//" on the last row via the Raw SCSS input field (Appearance > Advanced Settings) results in breaking the background image located on the login page. However, this does not occur when done in the Raw initial SCSS input field, or when ending with a CSS supported multi-line comment "/* */".

      This applies for both LMS and Workplace
      LMS version tested: 4.1.6
      MWP version tested: 4.1.6

            simonadams Simon Adams
            levivogel Levi Vogel
            Mark Johnson Mark Johnson
            Amaia Anabitarte Amaia Anabitarte
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            0 Vote for this issue
            Watchers:
            13 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 32 minutes
                32m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.