Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-80385

MDL-79428, which tried to backport MDL-43195, also accidentally reverted the fix for MDL-76865

XMLWordPrintable

    • MOODLE_401_STABLE, MOODLE_402_STABLE
    • MOODLE_401_STABLE, MOODLE_402_STABLE
    • MDL-80385-401
    • Hide

      Repeat steps from MDL-76865, which are:

      Using a fresh installation from the latest weekly release branch...

      1. Add a new File cache store instance called "local_file", set the directory name to an empty directory (e.g. "/tmp/muc") and tick auto create directory option if required.
      2. Add another new File cache store instance called "stacked_file", set the directory name to a different empty directory (e.g. "/tmp/muc2") and tick auto create directory option if required.
      3. Edit the core/coursemodinfo definition store mappings and set the primary store to local_file and the final store to stacked_file.
      4. Create a new empty course page, no need to add any activities.
      5. Change the default "General" heading of your new course page using the in-place editor to prime both cache stores.
      6. Remove any directories inside /tmp/muc/core_coursemodinfo to clear the local cache, but leave the stacked cache primed.
      7. Change the section 1 heading a second time.
      8. Before fix: Observe the web service request to core_update_inplace_editable takes a very long time to return anything (Maximum lock wait time * number of store instances) without this patch.
        After fix: The web service returned promptly and the section heading updates without a long wait, as in step 5.
      Show
      Repeat steps from MDL-76865 , which are: Using a fresh installation from the latest weekly release branch... Add a new File cache store instance called "local_file", set the directory name to an empty directory (e.g. "/tmp/muc") and tick auto create directory option if required. Add another new File cache store instance called "stacked_file", set the directory name to a different empty directory (e.g. "/tmp/muc2") and tick auto create directory option if required. Edit the core/coursemodinfo definition store mappings and set the primary store to local_file and the final store to stacked_file. Create a new empty course page, no need to add any activities. Change the default "General" heading of your new course page using the in-place editor to prime both cache stores. Remove any directories inside /tmp/muc/core_coursemodinfo to clear the local cache, but leave the stacked cache primed. Change the section 1 heading a second time. Before fix: Observe the web service request to core_update_inplace_editable takes a very long time to return anything (Maximum lock wait time * number of store instances) without this patch. After fix: The web service returned promptly and the section heading updates without a long wait, as in step 5.

      This commit on the 402 branch https://github.com/moodle/moodle/commit/988e48eb7f65146a8e0ebfb372a90dc663bdb42c#diff-c7c891adfdf9449f05ebba03a476ca380c038ef189cb47012f49852c662fa69e includes reverting the fix for MDL-76865 as well as the backport.

      The 401 branch is also affected.

      This needs to be sorted out.

            pholden Paul Holden
            timhunt Tim Hunt
            Tim Hunt Tim Hunt
            Ilya Tregubov Ilya Tregubov
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            1 Vote for this issue
            Watchers:
            18 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 47 minutes
                1h 47m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.