Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4.6, 4.5.2
Affects Version/s: 4.3, 4.4, 4.4.5, 4.5.1
Component/s: Authentication
Labels:
- CatalystIT
- ci
- partner
- release_notes
- triaged

Affected Branches:
MOODLE_403_STABLE, MOODLE_404_STABLE, MOODLE_405_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/bwalkerl/moodle
Pull 4.4 Branch:
~~MDL-80468~~-factorpage-44
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...bwalkerl:moodle:MDL-80468-factorpage-44
Pull 4.5 Branch:
~~MDL-80468~~-factorpage-45
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...bwalkerl:moodle:MDL-80468-factorpage-45
Pull Main Branch:
~~MDL-80468~~-factorpage-m
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...bwalkerl:moodle:MDL-80468-factorpage-m
Testing Instructions:
Hide

Prerequisites

Install factor_exemption: In a terminal, run the following command to clone the plugin:

git clone -b MOODLE_403_STABLE git@github.com:catalyst/moodle-factor_exemption.git admin/tool/mfa/factor/exemption

Login as administrator and complete the Moodle upgrade

Testing

Visit admin/search.php and navigate to Plugins, scroll down to the Admin tools section and look for Multi-factor authentication

Confirm you see "Manage User Exemptions" under Multi-factor authentication on the admin/search.php page

Click on "Manage User Exemptions"

Confirm you land on a page titled "Manage User Exemptions"
Show
Prerequisites Install factor_exemption: In a terminal, run the following command to clone the plugin: git clone -b MOODLE_403_STABLE git@github.com:catalyst /moodle-factor_exemption .git admin /tool/mfa/factor/exemption Login as administrator and complete the Moodle upgrade Testing Visit admin/search.php and navigate to Plugins, scroll down to the Admin tools section and look for Multi-factor authentication Confirm you see "Manage User Exemptions" under Multi-factor authentication on the admin/search.php page Click on "Manage User Exemptions" Confirm you land on a page titled "Manage User Exemptions"
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-80468~~ using repository: https://github.com/bwalkerl/moodle

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-80468-factorpage-44 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-80468-factorpage-45 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-80468-factorpage-m | CI Job]

_{More information about this report}

Built on: Wed 11 Dec 2024 04:48:29 AM UTC
Show
Code verified against automated checks. Checked MDL-80468 using repository: https://github.com/bwalkerl/moodle MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-80468-factorpage-44 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-80468-factorpage-45 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-80468-factorpage-m | CI Job ] More information about this report Built on: Wed 11 Dec 2024 04:48:29 AM UTC
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-80468~~-factorpage-43

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17430/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59441/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59442/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-80468~~-factorpage-44

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17431/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59443/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59444/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-80468~~-factorpage-45

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17432/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59445/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59446/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-80468~~-factorpage-m

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17433/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59447/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59448/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59449/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59450/ App tests (stable app version)

Built on: Wed Nov 20 06:25:53 AM UTC 2024
Show
Launching automatic jobs for branch MDL-80468 -factorpage-43 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17430/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59441/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59442/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-80468 -factorpage-44 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17431/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59443/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59444/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-80468 -factorpage-45 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17432/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59445/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59446/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-80468 -factorpage-m https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17433/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59447/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59448/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59449/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59450/ App tests (stable app version) Built on: Wed Nov 20 06:25:53 AM UTC 2024

When viewing the MFA submenu for factors, if a factor wishes to define a subpage, it is inaccessible from the admin/search.php page as it will not be displayed.

The factor loader has a subtle issue where it only loads factor settings when $ADMIN->fulltree is set, so external pages arent registered to the admin tree. The fix is here from fixing it for a client on 4.1 (with attached faulty whitespace )

https://github.com/catalyst/moodle-tool_mfa/pull/441/files

Replication instructions:

1. Install https://github.com/catalyst/moodle-factor_exemption

2. Enable factor in MFA menu

3. Verify that "Manage user exemptions" is NOT present in the MFA submenu in admin/search.php

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

0001-Add-return-type-declarations.patch
2 kB
16/Jan/25 12:22 PM
MDL-80468.png
278 kB
16/Jan/25 1:40 PM
mfa subpages - after patch.png
11 kB
18/Apr/24 10:12 AM

Assignee:: Benjamin Walker

Reporter:: Peter Burnett

Peer reviewer:: Kevin Pham

Integrator:: Jun Pataleta

Tester:: Ron Carl Alfon Yu

Participants:: Andrew Lyons, Benjamin Walker, CiBoT, Ilya Tregubov, Jun Pataleta, Kevin Pham, Peter Burnett, Ron Carl Alfon Yu

Votes:: 0 Vote for this issue

Watchers:: 16 Start watching this issue

Created:: 20/Dec/23 2:11 PM

Updated:: 10/Feb/25 4:55 PM

Resolved:: 17/Jan/25 1:11 AM

Estimated:

Remaining:

Logged:

4h 2m

Details

Description

Attachments

Attachments

Activity

People

Dates

Time Tracking

Clockify