Loading...

XML

Word

Printable

Type: Improvement
Resolution: Fixed
Priority: Minor
Fix Version/s: 5.0
Affects Version/s: 4.5
Component/s: Themes
Labels:

Affected Branches:
MOODLE_405_STABLE
Fixed Branches:
MOODLE_500_STABLE
Epic Link:
Bootstrap 5.x Upgrade
Pull from Repository:
https://github.com/roland04/moodle.git
Pull Main Branch:
~~MDL-80519~~-main
Pull Main Diff URL:
https://github.com/roland04/moodle/compare/7a318d5c85...MDL-80519-main
Documentation link:
https://github.com/moodle/devdocs/pull/1257
Testing Instructions:
Hide

Setup

Download and install block_bs4compat.zip

Add the "Bootstrap 4 compatibility" block to your dashboard

Test

Click on Check compatibility in the installed block

Confirm the examples in the "Bootstrap 4 compatibility - Check compatibility" page are correctly displayed

Enable "themedesignermode" in Site administration > Appearance > Advanced theme settings

Go back again to "Bootstrap 4 compatibility - Check compatibility" page

Confirm the examples in the page are displayed with deprecation styles like the following:
Show
Setup Download and install block_bs4compat.zip Add the "Bootstrap 4 compatibility" block to your dashboard Test Click on Check compatibility in the installed block Confirm the examples in the "Bootstrap 4 compatibility - Check compatibility" page are correctly displayed Enable "themedesignermode" in Site administration > Appearance > Advanced theme settings Go back again to "Bootstrap 4 compatibility - Check compatibility" page Confirm the examples in the page are displayed with deprecation styles like the following:
Pre-check results:
Hide

Fails against automated checks.

Checked ~~MDL-80519~~ using repository: https://github.com/roland04/moodle.git

main [branch: MDL-80519-main | CI Job]

Error: The ~~MDL-80519~~-main branch at https://github.com/roland04/moodle.git does not apply clean to origin/main

Error: Merge conflict(s) in file(s):

Error: theme/boost/style/moodle.css

Error: theme/classic/style/moodle.css

Should these errors be fixed?

Built on: Fri Feb 7 02:55:32 PM UTC 2025
Show
Fails against automated checks. Checked MDL-80519 using repository: https://github.com/roland04/moodle.git main [branch: MDL-80519-main | CI Job ] Error: The MDL-80519 -main branch at https://github.com/roland04/moodle.git does not apply clean to origin/main Error: Merge conflict(s) in file(s): Error: theme/boost/style/moodle.css Error: theme/classic/style/moodle.css Should these errors be fixed? Built on: Fri Feb 7 02:55:32 PM UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-80519~~-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18350/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62798/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62799/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62800/ Behat (Firefox - classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62801/ App tests (stable app version) / complete) --> unrelated failure caused by browser update, please ignore.

Built on: Tue Feb 25 01:30:30 PM UTC 2025
Show
Launching automatic jobs for branch MDL-80519 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18350/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62798/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62799/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62800/ Behat (Firefox - classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62801/ App tests (stable app version) / complete) --> unrelated failure caused by browser update, please ignore. Built on: Tue Feb 25 01:30:30 PM UTC 2025

Story Points:
5
Sprint:
HQ 2025 Sprint I1.1 Moppies

During the Bootstrap upgrade from version 4 to 5, some features will be dropped.
We should create a compatibility layer to help third-party plugins in the migration process.

Whenever possible, every BS feature tackled in ~~MDL-79914~~ or ~~MDL-79917~~ should be added to the backward compatibility layer in bs4-compat.scss.
To test this compatibility a new block_bs4compat has been created

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

(1) 2 Passed -- (Main)MDL-80519.png
87 kB
27/Feb/25 10:36 AM
(1) 5 Passed -- (Main)MDL-80519.png
142 kB
27/Feb/25 10:36 AM
block_bs4compat.zip
229 kB
07/Feb/25 10:00 PM
screenshot-2.png
137 kB
07/Feb/25 10:37 PM
screenshot-3.png
126 kB
07/Feb/25 10:37 PM
screenshot-4.png
128 kB
07/Feb/25 10:39 PM
screenshot-5.png
106 kB
07/Feb/25 10:39 PM

has a non-specific relationship to

MDL-84951 Fix SCSS deprecation failures

Closed

MDL-79914 Investigate refactor possibilities of Bootstrap 4 features that will be dropped in version 5

Closed

MDL-79917 Investigate the creation of a Bootstrap v5 SCSS "bridge" before the full upgrade

Closed

MDL-75670 Refactor Bootstrap form layouts preparing them for Bootstrap 5

Closed

MDL-80259 Refactor .badge-[warning|info|...] and .badge-pill classes dropped in Bootstrap 5

Closed

MDL-80395 Refactor dropped mixins in Bootstrap 5

Closed

MDL-80396 Refactor .media component dropped in Bootstrap 5

Closed

MDL-80397 Refactor some .card-* helpers dropped in Bootstrap 5

Closed

MDL-81819 Refactor .close class renamed in Bootstrap 5

Closed

MDL-81823 Refactor .rounded-[sm|lg] classes removed in Bootstrap 5

Closed

has been marked as being related by

MDL-81818 Refactor .no-gutters class renamed in Bootstrap 5

Closed

has to be done before

MOBILE-4598 Support some of the features included in the Bootstrap 5 bridge

Closed

MDL-84465 Final deprecation of Bootstrap 4 compatibility

Open

is blocked by

MDL-75669 Upgrade the Boost theme with Bootstrap 5.x

Closed

mentioned in: Page Loading...; Page Loading...; Page Loading...; Page Loading...

(5 has a non-specific relationship to, 1 has been marked as being related by, 2 has to be done before, 1 is blocked by, 4 mentioned in)

Assignee:: Mikel Martín Corrales

Reporter:: Mikel Martín Corrales

Peer reviewer:: Laurent David

Integrator:: Ferran Recio

Tester:: Kim Jared Lucas

Participants:: CiBoT, Ferran Recio, Jun Pataleta, Kim Jared Lucas, Laurent David, Mikel Martín Corrales, Simey Lameze

Votes:: 0 Vote for this issue

Watchers:: 11 Start watching this issue

Created:: 03/Jan/24 8:09 PM

Updated:: 07/Apr/25 6:29 PM

Resolved:: 28/Feb/25 12:56 AM

Estimated:

Remaining:

Logged:

3h 7m

Details

Setup

Test

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify