Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-80598

Bigbluebuttonbn adhoc tasks do not gracefully handle missing course modules or users

    XMLWordPrintable

Details

    Description

      We've found occasionally we get a few stuck adhoc tasks which fail because either the user or the course module they are referencing does not exist anymore (presumably deleted)

      Example:

      Adhoc task failed: mod_bigbluebuttonbn\task\completion_update_state, Invalid module ID: {$a}Backtrace: line 252 of /mod/bigbluebuttonbn/classes/local/proxy/bigbluebutton_proxy.php: call to get_course_and_cm_from_instance()
      

       

      Adhoc task failed: mod_bigbluebuttonbn\task\send_recording_ready_notification,mod_bigbluebuttonbn\task\base_send_notification::get_instance(): Return value must be of type mod_bigbluebuttonbn\instance, null returned
      line 182 of /mod/bigbluebuttonbn/classes/task/base_send_notification.php: call to mod_bigbluebuttonbn\task\base_send_notification->get_instance()

       

       

      The tasks should ideally check if the module or user exists at all, and if not then just exit early (since there is nothing to do)

      It is fairly involved to recreate this since you need a functioning site, but I think the problem is easy enough to understand that it is not necessary.

       

      Attachments

        Issue Links

          Activity

            People

              matthewhilton Matthew Hilton
              matthewhilton Matthew Hilton
              Shamiso Jaravaza Shamiso Jaravaza
              Ferran Recio Ferran Recio
              CiBoT CiBoT
              Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 hours, 5 minutes
                  3h 5m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.