Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-80622

Improve the shadow element when dragging activity cards

XMLWordPrintable

    • MOODLE_404_STABLE
    • MOODLE_404_STABLE
    • MDL-80622-main
    • Hide

      Setup

      1. Login as administrator.
      2. Create a course with some sections and activities.

      Test drag&drop activity

      1. Access the course page and enable "Edit mode".
      2. Drag an activity with the mouse and wait until dropping it.
      3. Confirm that the "Shadow" element (dragImage) is the activity card without any top space. See the comparison below:
        1. (Wrong) Shadow element with top spacing.
        2. (Correct) Shadow element without top spacing.
      4. Confirm the activity is moved when dropping it using the course content or the course index.

      Test drag&drop section

      1. Drag a section (from its heading) with the mouse and wait until dropping it. 
      2. Confirm that the "Shadow" element (dragImage) is the section heading. There are no changes from this patch.
      3. Confirm the section is moved when dropping it using the course content or the course index.
      Show
      Setup Login as administrator. Create a course with some sections and activities. Test drag&drop activity Access the course page and enable "Edit mode". Drag an activity with the mouse and wait until dropping it. Confirm that the "Shadow" element (dragImage) is the activity card without any top space. See the comparison below: (Wrong) Shadow element with top spacing. (Correct) Shadow element without top spacing. Confirm the activity is moved when dropping it using the course content or the course index. Test drag&drop section Drag a section (from its heading) with the mouse and wait until dropping it.  Confirm that the "Shadow" element (dragImage) is the section heading. There are no changes from this patch. Confirm the section is moved when dropping it using the course content or the course index.
    • 3
    • HQ2024 Sprint I1.1 Moppies
    • Medium

      With the new additions in MDL-80219, the generated shadow element also contains the associated border when dragging activity cards to drop them elsewhere.
      This happens because the "Drag image" used in the DnD is the hole card (containing the separator etc) instead of the activity card.

        1. (1) 3 Passed -- (Main)MDL-80622.png
          71 kB
          Kim Jared Lucas
        2. (1) 4 Passed -- (Main)MDL-80622.png
          62 kB
          Kim Jared Lucas
        3. (2) 2 Passed -- (Main)MDL-80622.png
          62 kB
          Kim Jared Lucas
        4. (2) 3 Passed -- (Main)MDL-80622.png
          47 kB
          Kim Jared Lucas
        5. screenshot-1.png
          46 kB
          Mikel Martín Corrales
        6. screenshot-2.png
          50 kB
          Mikel Martín Corrales
        7. screenshot-3.png
          48 kB
          Mikel Martín Corrales
        8. screenshot-4.png
          43 kB
          Mikel Martín Corrales

            mikelmartíncorrales Mikel Martín Corrales
            mikelmartíncorrales Mikel Martín Corrales
            Carlos Escobedo Carlos Escobedo
            Ferran Recio Ferran Recio
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 4 hours, 47 minutes
                4h 47m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.