-
Bug
-
Resolution: Fixed
-
Minor
-
4.3
-
MOODLE_403_STABLE
-
MOODLE_402_STABLE, MOODLE_403_STABLE
-
MDL-80694-402 -
MDL-80694-403 -
Setup
- Download the test patch: MDL-80694.diff
- Open a terminal and go to your moodle instance's root folder
- Apply the following sample patch
git apply /path/to/MDL-80694.diff
Test
- Create a course in topics format
- Turn editing mode on
- Edit a section name using inplace editable, change it to any value
- Edit a section name again and change it to 'locked'
- Make sure the inplace editable control is no longer available for this section and it is no longer editable, and there are no errors on the page
After test
Make sure to revert your changes. e.g. "git reset --hard"
Setup Download the test patch: MDL-80694.diff Open a terminal and go to your moodle instance's root folder Apply the following sample patch git apply /path/to/MDL-80694.diff Test Create a course in topics format Turn editing mode on Edit a section name using inplace editable, change it to any value Edit a section name again and change it to 'locked' Make sure the inplace editable control is no longer available for this section and it is no longer editable, and there are no errors on the page After test Make sure to revert your changes. e.g. " git reset --hard " - Download the test patch: MDL-80694.diff
-
WP Sprint 2024-I1.1 (Atlantic)
I have an inplace editable element that is only one-way action.
It is a select element with two values. Transition from A->B is allowed and from B->A is not
(actual example - appointment booking, teacher can change the "Wait-listed" status into "Booked" but not vice versa)
So basically it is an editable element but after you edit it, the plugin callback returns an instance of inplace_editable class but with 'editable' property set to false.
This results in an exception:
Error in response - Missing following required key in a single structure: editicon
|
Error code: invalidresponse
|
* line 446 of /lib/external/classes/external_api.php: invalid_response_exception thrown
|
* line ? of unknownfile: call to core_external\external_api::clean_returnvalue()
|
* line 259 of /lib/external/classes/external_api.php: call to call_user_func()
|
* line 88 of /lib/ajax/service.php: call to core_external\external_api::call_external_function()
|
- is a regression caused by
-
MDL-72289 Allow callers to customise the rendered icon of inplace editable elements
-
- Closed
-
