Moodle
  1. Moodle
  2. MDL-8068 Introduce Mnet 1.0 to Moodle core code
  3. MDL-8069

Hunt down and convert all hardcoded English strings in the source to use lang pack

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 1.8
    • Fix Version/s: 1.8
    • Component/s: MNet
    • Labels:
      None
    • Affected Branches:
      MOODLE_18_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE
    • Rank:
      33623

      Description

      Hunt down and convert all hardcoded English strings in the source to use lang pack, otherwise people can't translate them.

        Issue Links

          Activity

          Donal McMullan created issue -
          Martin Dougiamas made changes -
          Field Original Value New Value
          Assignee Martin Dougiamas [ dougiamas ] Donal McMullan [ donal@catalyst.net.nz ]
          Hide
          Martin Dougiamas added a comment -

          This is one is a pretty critical breach of the coding guidelines, I'm running into heaps of them.

          Basically the mnet strings need to be in the language pack mnet.php and you use either get_string() for normal usage or errorcode() when it's an error.

          Show
          Martin Dougiamas added a comment - This is one is a pretty critical breach of the coding guidelines, I'm running into heaps of them. Basically the mnet strings need to be in the language pack mnet.php and you use either get_string() for normal usage or errorcode() when it's an error.
          Martin Dougiamas made changes -
          Priority Minor [ 4 ] Blocker [ 1 ]
          Hide
          Donal McMullan added a comment -

          I've hunted down and replaced all the hardcoded strings I can find in the MNet and Auth sections. Please reopen this if you encounter any escapees, and note the offending file and section.

          Thanks

          Donal

          Show
          Donal McMullan added a comment - I've hunted down and replaced all the hardcoded strings I can find in the MNet and Auth sections. Please reopen this if you encounter any escapees, and note the offending file and section. Thanks Donal
          Donal McMullan made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Nicolas Martignoni made changes -
          Link This issue has been marked as being related by MDL-8151 [ MDL-8151 ]
          Martin Dougiamas made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          QA Assignee nobody
          Martin Dougiamas made changes -
          Workflow jira [ 18966 ] MDL Workflow [ 54620 ]
          Martin Dougiamas made changes -
          Workflow MDL Workflow [ 54620 ] MDL Full Workflow [ 83737 ]

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: