Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-8068 Introduce Mnet 1.0 to Moodle core code
  3. MDL-8069

Hunt down and convert all hardcoded English strings in the source to use lang pack

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 1.8
    • Fix Version/s: 1.8
    • Component/s: MNet
    • Labels:
      None
    • Affected Branches:
      MOODLE_18_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE

      Description

      Hunt down and convert all hardcoded English strings in the source to use lang pack, otherwise people can't translate them.

        Gliffy Diagrams

          Issue Links

            Activity

            donal@catalyst.net.nz Donal McMullan created issue -
            dougiamas Martin Dougiamas made changes -
            Field Original Value New Value
            Assignee Martin Dougiamas [ dougiamas ] Donal McMullan [ donal@catalyst.net.nz ]
            Hide
            dougiamas Martin Dougiamas added a comment -

            This is one is a pretty critical breach of the coding guidelines, I'm running into heaps of them.

            Basically the mnet strings need to be in the language pack mnet.php and you use either get_string() for normal usage or errorcode() when it's an error.

            Show
            dougiamas Martin Dougiamas added a comment - This is one is a pretty critical breach of the coding guidelines, I'm running into heaps of them. Basically the mnet strings need to be in the language pack mnet.php and you use either get_string() for normal usage or errorcode() when it's an error.
            dougiamas Martin Dougiamas made changes -
            Priority Minor [ 4 ] Blocker [ 1 ]
            Hide
            donal@catalyst.net.nz Donal McMullan added a comment -

            I've hunted down and replaced all the hardcoded strings I can find in the MNet and Auth sections. Please reopen this if you encounter any escapees, and note the offending file and section.

            Thanks

            Donal

            Show
            donal@catalyst.net.nz Donal McMullan added a comment - I've hunted down and replaced all the hardcoded strings I can find in the MNet and Auth sections. Please reopen this if you encounter any escapees, and note the offending file and section. Thanks Donal
            donal@catalyst.net.nz Donal McMullan made changes -
            Status Open [ 1 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            mina Nicolas Martignoni made changes -
            Link This issue has been marked as being related by MDL-8151 [ MDL-8151 ]
            dougiamas Martin Dougiamas made changes -
            Status Resolved [ 5 ] Closed [ 6 ]
            QA Assignee nobody
            dougiamas Martin Dougiamas made changes -
            Workflow jira [ 18966 ] MDL Workflow [ 54620 ]
            dougiamas Martin Dougiamas made changes -
            Workflow MDL Workflow [ 54620 ] MDL Full Workflow [ 83737 ]

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  31/Mar/07