Moodle
  1. Moodle
  2. MDL-8080

Teacher can't use grade exception tab

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 1.7, 1.7.1, 1.7.2, 1.8
    • Fix Version/s: 1.7.3, 1.8.1, 1.9
    • Component/s: Gradebook
    • Labels:
      None
    • Affected Branches:
      MOODLE_17_STABLE, MOODLE_18_STABLE
    • Fixed Branches:
      MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE
    • Rank:
      29351

      Description

      I use the Moodle grade book for my class. Prior to 1.7 I could use the grade exception tab to exempt students from assignments. Version 1.7 will not allow me to do this. This was a very valuable tool on previous versions.

        Issue Links

          Activity

          Hide
          john marchant added a comment -

          I too have this problem. Here is what I posted in the forums:

          Hi, when the teacher clicks the Grade Exceptions tab, it says:

          Sorry, but you do not currently have permissions to do that (Manage grades)

          It works in one class, but not the others. That one class has all grades, if that is a factor (the other classes will be tested tomorrow.)

          Does anyone know how to fix this? The administrator role has no problem seeing this, so I'm not sure what is going on. The teacher is indeed in the teacher role for that class.

          The role has manage grades set to allow.

          Thanks for any help.

          I have Moodle 1.7 stable.

          Show
          john marchant added a comment - I too have this problem. Here is what I posted in the forums: Hi, when the teacher clicks the Grade Exceptions tab, it says: Sorry, but you do not currently have permissions to do that (Manage grades) It works in one class, but not the others. That one class has all grades, if that is a factor (the other classes will be tested tomorrow.) Does anyone know how to fix this? The administrator role has no problem seeing this, so I'm not sure what is going on. The teacher is indeed in the teacher role for that class. The role has manage grades set to allow. Thanks for any help. I have Moodle 1.7 stable.
          Hide
          Kenneth Newquist added a comment -

          I have the same issue, using Moodle 1.7 stable. I posted a tracker report of my own on the issue here:

          http://tracker.moodle.org/browse/MDL-8259

          We haven't been able to get it to work in any class; the only ones who can use this tab are the admins. For more details, see the above tracker report.

          Show
          Kenneth Newquist added a comment - I have the same issue, using Moodle 1.7 stable. I posted a tracker report of my own on the issue here: http://tracker.moodle.org/browse/MDL-8259 We haven't been able to get it to work in any class; the only ones who can use this tab are the admins. For more details, see the above tracker report.
          Hide
          Paul Ortman added a comment -

          Attached is a very simple patch that seems to solve the problem. It would appear the original code attempted to get the ID of the module where it likely wanted the id of the course. Anyway, this might prove to be a fix.

          Show
          Paul Ortman added a comment - Attached is a very simple patch that seems to solve the problem. It would appear the original code attempted to get the ID of the module where it likely wanted the id of the course. Anyway, this might prove to be a fix.
          Hide
          Paul Ortman added a comment -

          This issue was present in both 1.7 and 1.7.1+ I've taken a crack at seeing if I could patch it. The patch needs to be applied to the /grade/exceptions.php file.

          Show
          Paul Ortman added a comment - This issue was present in both 1.7 and 1.7.1+ I've taken a crack at seeing if I could patch it. The patch needs to be applied to the /grade/exceptions.php file.
          Hide
          Kenneth Newquist added a comment -

          This patch worked for me. How do we go about getting it into the Moodle 1.7.2 update?

          Show
          Kenneth Newquist added a comment - This patch worked for me. How do we go about getting it into the Moodle 1.7.2 update?
          Hide
          Dixie Harrison added a comment -

          I updated my 1.7.1+ this morning and added this patch but it didn't work for me. I commented out lines 13 through 19 in the grade/exceptions.php file and added the new ones. Is that what I was supposed to do?

          Show
          Dixie Harrison added a comment - I updated my 1.7.1+ this morning and added this patch but it didn't work for me. I commented out lines 13 through 19 in the grade/exceptions.php file and added the new ones. Is that what I was supposed to do?
          Hide
          Paul Ortman added a comment -

          @Dixie

          I just checked the patch applies cleanly to the most recent version of moodle 1.7.1+ I can't test how well it works, b/c I can't just upgrade our site willy-nilly.

          Perhaps you're not applying the patch correctly? This is a fairly simple that reads, in english:

          In the grades/exceptions.php file, find line 15 that reads:

          {{

          { require_capability('moodle/course:managegrades', get_context_instance(CONTEXT_MODULE, $id)); }

          }}

          and replace it with

          {{

          { require_capability('moodle/course:managegrades', get_context_instance(CONTEXT_COURSE, $id)); }

          }}

          The automated, "correct" way to do this is to use the "patch" tool. For this patch, you would:

          1) cd grades/
          2) wget http://tracker.moodle.org/secure/attachment/10665/patch_to_allow_teachers_to_edit_grade_exceptions.patch
          3) cat patch_to_allow_teachers_to_edit_grade_exceptions.patch | patch -p0

          that is all

          Show
          Paul Ortman added a comment - @Dixie I just checked the patch applies cleanly to the most recent version of moodle 1.7.1+ I can't test how well it works, b/c I can't just upgrade our site willy-nilly. Perhaps you're not applying the patch correctly? This is a fairly simple that reads, in english: In the grades/exceptions.php file, find line 15 that reads: {{ { require_capability('moodle/course:managegrades', get_context_instance(CONTEXT_MODULE, $id)); } }} and replace it with {{ { require_capability('moodle/course:managegrades', get_context_instance(CONTEXT_COURSE, $id)); } }} The automated, "correct" way to do this is to use the "patch" tool. For this patch, you would: 1) cd grades/ 2) wget http://tracker.moodle.org/secure/attachment/10665/patch_to_allow_teachers_to_edit_grade_exceptions.patch 3) cat patch_to_allow_teachers_to_edit_grade_exceptions.patch | patch -p0 that is all
          Hide
          Dixie Harrison added a comment -

          Well, I suppose it helps when you apply it correctly <G> I've fixed it and it works great now.

          Thanx!!

          Show
          Dixie Harrison added a comment - Well, I suppose it helps when you apply it correctly <G> I've fixed it and it works great now. Thanx!!
          Hide
          Brian Pool added a comment -

          Thanks for the info. I edited the php file on my server and everyone is again happy now! Thanks!

          Show
          Brian Pool added a comment - Thanks for the info. I edited the php file on my server and everyone is again happy now! Thanks!
          Hide
          Kenneth Newquist added a comment -

          This problem persists in Moodle 1.8.0. The patch fixes it, but this really needs to make its way in to core Moodle.

          Show
          Kenneth Newquist added a comment - This problem persists in Moodle 1.8.0. The patch fixes it, but this really needs to make its way in to core Moodle.
          Hide
          Nicolas Martignoni added a comment -

          Raising to critical. This impairs grade functioning in 1.8 too.

          Suggest fixing as soon as possible, as we have a patch.

          Show
          Nicolas Martignoni added a comment - Raising to critical. This impairs grade functioning in 1.8 too. Suggest fixing as soon as possible, as we have a patch.
          Hide
          Dan Poltawski added a comment -

          Hi, i've applied this patch to CVS. Thanks for the report and patch. Please test

          Show
          Dan Poltawski added a comment - Hi, i've applied this patch to CVS. Thanks for the report and patch. Please test
          Hide
          Nicolas Martignoni added a comment -

          Works on 1.8.3+. New gradebook on 1.9. Closing.

          Show
          Nicolas Martignoni added a comment - Works on 1.8.3+. New gradebook on 1.9. Closing.

            People

            • Votes:
              9 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: