Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-80819

Update moodle_minimum_php_version_is_met() to current values

XMLWordPrintable

    • MOODLE_401_STABLE, MOODLE_402_STABLE, MOODLE_403_STABLE, MOODLE_404_STABLE
    • MOODLE_401_STABLE, MOODLE_402_STABLE, MOODLE_403_STABLE
    • MDL-80819_401
    • MDL-80819_403
    • Hide

      main tests

      1. Checkout the "main" branch.
      2. Switch to use PHP 8.0 (or lower) in the CLI.
      3. Ensure that there isn't any config.php file or site installed for that checkout.
      4. Run: php admin/cli/install.php
      5. Verify that, immediately, before anything else, you get the message:

        Moodle 4.4 or later requires at least PHP 8.1.0 (currently using version 8.0.x)

      6. Switch to use PHP 8.1 (or higher) in the CLI.
      7. Run: php admin/cli/install.php
      8. Verify that the installation begins and you see the "Moodle ASCII logo" and other stuff.
      9. Cancel (Control-C) the installation, we don't need to install anything.

      403 and 402 tests

      1. Note: Only need to run this once. Code and restrictions are the same.
      2. Checkout the "MOODLE_403_STABLE" branch.
      3. Switch to use PHP 7.4 (or lower) in the CLI.
      4. Ensure that there isn't any config.php file or site installed for that checkout.
      5. Run: php admin/cli/install.php
      6. Verify that, immediately, before anything else, you get the message:

        Moodle 4.2 or later requires at least PHP 8.0.0 (currently using version 7.4.x)

      7. Switch to use PHP 8.0 (or higher) in the CLI.
      8. Run: php admin/cli/install.php
      9. Verify that the installation begins and you see the "Moodle ASCII logo" and other stuff.
      10. Cancel (Control-C) the installation, we don't need to install anything.

      401 tests

      1. Checkout the "MOODLE_401_STABLE" branch.
      2. Switch to use PHP 7.3 (or lower) in the CLI.
      3. Ensure that there isn't any config.php file or site installed for that checkout.
      4. Run: php admin/cli/install.php
      5. Verify that, immediately, before anything else, you get the message:

        Moodle 4.1 or later requires at least PHP 7.4.0 (currently using version 7.3.x)

      6. Switch to use PHP 7.4 (or higher) in the CLI.
      7. Run: php admin/cli/install.php
      8. Verify that the installation begins and you see the "Moodle ASCII logo" and other stuff.
      9. Cancel (Control-C) the installation, we don't need to install anything.
      Show
      main tests Checkout the "main" branch. Switch to use PHP 8.0 (or lower) in the CLI. Ensure that there isn't any config.php file or site installed for that checkout. Run: php admin/cli/install.php Verify that, immediately, before anything else, you get the message: Moodle 4.4 or later requires at least PHP 8.1.0 (currently using version 8.0.x) Switch to use PHP 8.1 (or higher) in the CLI. Run: php admin/cli/install.php Verify that the installation begins and you see the "Moodle ASCII logo" and other stuff. Cancel (Control-C) the installation, we don't need to install anything. 403 and 402 tests Note: Only need to run this once. Code and restrictions are the same. Checkout the "MOODLE_403_STABLE" branch. Switch to use PHP 7.4 (or lower) in the CLI. Ensure that there isn't any config.php file or site installed for that checkout. Run: php admin/cli/install.php Verify that, immediately, before anything else, you get the message: Moodle 4.2 or later requires at least PHP 8.0.0 (currently using version 7.4.x) Switch to use PHP 8.0 (or higher) in the CLI. Run: php admin/cli/install.php Verify that the installation begins and you see the "Moodle ASCII logo" and other stuff. Cancel (Control-C) the installation, we don't need to install anything. 401 tests Checkout the "MOODLE_401_STABLE" branch. Switch to use PHP 7.3 (or lower) in the CLI. Ensure that there isn't any config.php file or site installed for that checkout. Run: php admin/cli/install.php Verify that, immediately, before anything else, you get the message: Moodle 4.1 or later requires at least PHP 7.4.0 (currently using version 7.3.x) Switch to use PHP 7.4 (or higher) in the CLI. Run: php admin/cli/install.php Verify that the installation begins and you see the "Moodle ASCII logo" and other stuff. Cancel (Control-C) the installation, we don't need to install anything.

      It seems that, since Moodle 3.7, we have forgotten to update the moodle_minimum_php_version_is_met() function values to actual ones.

      That function is executed BEFORE the environment stuff, by different scripts (see moodle_require_minimum_php_version() uses, namely: install, cli install, install database and admin index.

      Right now, it's showing, since MDL-63276, the following (clearly outdated) values:

      $minimumversion = '7.1.0';
      $moodlerequirementchanged = '3.7';
      

      So this issue is about to:

      • For all supported (security included) branches, find which are the correct values.
      • Provide a patch with them fixed. Test, test.
      • Ensure that, in the "Moodle X.Y requirements" issues/epics we don't forget about to, always, check if a change like the ones performed here are needed. (done commented as TODO-5.3 @ MDL-79809, so future clones of it should, always, include the point).

      Ciao

        1. MDL-80819-401.png
          MDL-80819-401.png
          85 kB
        2. MDL-80819-403.png
          MDL-80819-403.png
          123 kB
        3. MDL-80819-main test.png
          MDL-80819-main test.png
          175 kB

            stronk7 Eloy Lafuente (stronk7)
            stronk7 Eloy Lafuente (stronk7)
            Paul Holden Paul Holden
            Jun Pataleta Jun Pataleta
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 33 minutes
                2h 33m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.