Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-80828

Activity action menu should not have a submenu panel when only two choices are available

XMLWordPrintable

    • MOODLE_403_STABLE
    • MOODLE_404_STABLE
    • MDL-80828-main
    • Hide

      Covered by Behat tests.
      Manual test is NOT mandatory

      Manual test

      1. Login as administrator
      2. Confirm that "allowstealth" setting is disabled in "Site Administration"
      3. Create a new course
      4. Open the "Announcements" forum action menu
      5. Confirm that "Hide" option is displayed
      6. Click on Hide
      7. Confirm that the activity is now hidden
      8. Open the "Announcements" forum action menu
      9. Confirm that "Show" option is displayed
      10. Click on Show
      11. Confirm that the activity is visible again
      Show
      Covered by Behat tests. Manual test is NOT mandatory Manual test Login as administrator Confirm that "allowstealth" setting is disabled in "Site Administration" Create a new course Open the "Announcements" forum action menu Confirm that "Hide" option is displayed Click on Hide Confirm that the activity is now hidden Open the "Announcements" forum action menu Confirm that "Show" option is displayed Click on Show Confirm that the activity is visible again
    • 2
    • HQ 2024 Sprint I1.2 Moppies

      When an activity has only show/hide visibility options, the actions menu item should not show a subpanel. Instead, it should do the same as the section action menu (showing only the show or hide action directly into the menu). However, when the activity has three options (show/hide/stealth) or stealth/hide ones, the options should be displayed as subpanels because they are not obvious and need extra descriptions.

      From the technical perspective those are the list of possible scenarios:

      • If allowstealth (Administration > Advanced features) is enabled. The options are always displayed in a subpanel as it is now
      • If allowstealth (Administration > Advanced features) is disabled there are two scenarios:
        • If the activity is inside a visible section: do NOT display the subpanel but only the show or hide action. This is the only new scenario.
        • If the activity is inside a hidden section: show the subpanel with the stealth and hide options as it is now.

       

      To check this:

      • Create a course C1 and an activity A1 (Assignment)
      • Enable allowstealth
      • Go in editing mode
      • Click on the action menu next to A1
      • Ensure that you have an availability menu that is leading to 3 options

      Now disable stealth mode:

      • In the same drop down menu (action menu) you should have one option: hide or show (and not any availability submenu)

            mikelmartíncorrales Mikel Martín Corrales
            laurent.david@moodle.com Laurent David
            Carlos Escobedo Carlos Escobedo
            Ferran Recio Ferran Recio
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            1 Vote for this issue
            Watchers:
            9 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day, 7 hours
                1d 7h

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.