Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.2.7, 4.3.4
Affects Version/s: 4.3
Component/s: Backup, Unit tests
Labels:
- CatalystIT
- ci
- partner
- release_notes

Affected Branches:
MOODLE_403_STABLE
Fixed Branches:
MOODLE_402_STABLE, MOODLE_403_STABLE
Pull from Repository:
https://github.com/Fragonite/moodle
Pull 4.2 Branch:
mdl-80917-402
Pull 4.2 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_402_STABLE...Fragonite:moodle:mdl-80917-402
Pull 4.3 Branch:
mdl-80917-403
Pull 4.3 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_403_STABLE...Fragonite:moodle:mdl-80917-403
Pull Main Branch:
mdl-80917-main
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...Fragonite:moodle:mdl-80917-main
Testing Instructions:
Hide

Reproduction:

From the site directory, install the minimal dummy plugin:

git clone https://github.com/Fragonite/moodle-local_tracker_demo.git local/tracker_demo

Testing:

Make sure PHPUnit is initialised for the site.

Navigate to the site directory from the CLI.

Run:

php vendor/bin/phpunit --testsuite core_backup_testsuite --filter test_course_copy

Verify all tests pass.
Show
Reproduction: From the site directory, install the minimal dummy plugin: git clone https: //github.com/Fragonite/moodle-local_tracker_demo.git local/tracker_demo Testing: Make sure PHPUnit is initialised for the site. Navigate to the site directory from the CLI. Run: php vendor/bin/phpunit --testsuite core_backup_testsuite --filter test_course_copy Verify all tests pass.

The asynchronous_copy_task class does not clear the course cache after running, yet it updates the course record. This can cause problems, such as failing core unit tests if get_fast_modinfo is called from a \core\event\course_restored handler.

1) core_backup\copy_helper_test::test_course_copy

Failed asserting that '0' matches expected 1582386400.

2) core_backup\copy_helper_test::test_course_copy_no_users

Failed asserting that '0' matches expected 1582386400.

3) core_backup\copy_helper_test::test_course_copy_students_data

Failed asserting that '0' matches expected 1582386400.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-80917.png
104 kB
29/Feb/24 9:09 AM

Assignee:: Alexander Van der Bellen

Reporter:: Alexander Van der Bellen

Peer reviewer:: Dmitrii Metelkin

Integrator:: Sara Arjona (@sarjona)

Tester:: Ron Carl Alfon Yu

Participants:: Alexander Van der Bellen, CiBoT, Dmitrii Metelkin, Ron Carl Alfon Yu, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Created:: 13/Feb/24 4:54 PM

Updated:: 17/Apr/24 4:28 PM

Resolved:: 01/Mar/24 1:35 PM

Estimated:

Remaining:

Logged:

47m

Details

Reproduction:

Testing:

Description

Attachments

Attachments

Activity

People

Dates

Time Tracking

Clockify