-
Improvement
-
Resolution: Fixed
-
Minor
-
4.4
-
MOODLE_404_STABLE
-
MOODLE_404_STABLE
-
MDL-80923-main -
Covered by behat tests.
MANUAL TESTING IS NOT REQUIRED (because the patch is covered by automated tests).
However, these are the steps for manually testing it.Setup
- Download the attached basic-scenario.feature
. - Run the following command to create a course with a few subsection activities:
php admin/tool/generator/cli/runtestscenario.php --feature="absolute/path/to/file.feature"
It might fail while trying to create the users if s1 and s2 already exist in your local instance. If that's the case, this error can be ignored.
Manual test
- Login as admin.
- Go to the course (Course 1 => Custom sections and Course 2 => Weekly sections).
- Edit mode on.
- Open the Section action menu and go to Edit settings.
- Check "Section name" field doesn't contain a "Custom" checkbox.
- Check "Section name" input text displays the expected default name as a placeholder for the section (General for section 0 and "New section" or the week date for the rest of the sections).
- Change the Section name, save changes and confirm the section has been renamed.
Covered by behat tests. MANUAL TESTING IS NOT REQUIRED (because the patch is covered by automated tests). However, these are the steps for manually testing it. Setup Download the attached basic-scenario.feature . Run the following command to create a course with a few subsection activities: php admin/tool/generator/cli/runtestscenario.php --feature="absolute/path/to/file.feature" It might fail while trying to create the users if s1 and s2 already exist in your local instance. If that's the case, this error can be ignored. Manual test Login as admin. Go to the course (Course 1 => Custom sections and Course 2 => Weekly sections). Edit mode on. Open the Section action menu and go to Edit settings. Check "Section name" field doesn't contain a "Custom" checkbox. Check "Section name" input text displays the expected default name as a placeholder for the section (General for section 0 and "New section" or the week date for the rest of the sections). Change the Section name, save changes and confirm the section has been renamed. - Download the attached basic-scenario.feature
-
2
-
HQ 2024 Sprint I1.2 Moppies
While working on MDL-80460, the UX team proposed to remove the "Custom" checkbox available in the Edit settings page for sections in ALL course formats:
The custom checkbox behaviour is a creative solution from a time when HTML forms were far more basic. Nowadays, HTML5 forms have more advanced features that can be used in those cases.
The proposal is to stop using a "defaultcustom" field for the section name and replace it by a regular input field with a placeholder. The placeholder will display the default name when the field is empty but will allow the user to set a custom value when needed.
This is an example of a boostrap field using placeholders:
<div class="form-group"> |
<label for="fieldId">Name</label> |
<input
|
type="test" |
class="form-control" |
id="fieldId" |
placeholder="Default section name" |
>
|
</div>
|
The new behaviour is similar to the in-place editable used on the course page to rename sections, and there are no complaints about how it works.
- has to be done after
-
MDL-80939 UX review - Remove the Custom checkbox from the Settings page for the topics course format
-
- Closed
-
- has to be done before
-
-
- Open
-
- is blocked by
-
-
- Closed
-
- Testing discovered
-
MDL-81050 Using "Edit section name" inline from the section page doesn't propagate the new section name
-
- Closed
-
- mentioned in
-
Page Loading...
