Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-8101

Inline styles in function "print_simple_box_start"

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.8
    • Fix Version/s: 1.8
    • Component/s: Themes
    • Labels:
      None
    • Affected Branches:
      MOODLE_18_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE

      Description

      Great that some more tables on the frontpage are gone The new function "print_simple_box_start" looks like a great solution for backward compatibility.

      I suppose colour and width are taken over from pre CSS times.But the inline styles that are used are reducing flexibility. The inline style has the highest possible specificity and is hard to overwrite. You can overwrite it only with "!important" - and that's really bad because you loose much flexibility. All html attributes you can overwrite with CSS but not inline styles.

      Did you consider other solutions? The only solution I know is to take colour and width out of the box definition. These values should really go into the CSS files.

      Please let's take them out if there aren't better solutions.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dougiamas Martin Dougiamas
              Reporter:
              urshunkler Urs Hunkler
              Tester:
              Nobody
              Participants:
              Component watchers:
              Bas Brands
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                31/Mar/07