Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-81146

Buttons not disabled when form submitted in Chrome browser

XMLWordPrintable

    • MOODLE_402_STABLE, MOODLE_403_STABLE
    • MOODLE_403_STABLE, MOODLE_404_STABLE
    • MDL-81146_disable_buttons-403
    • MDL-81146_disable_buttons
    • Hide

      (Based on the testing instructions from MDL-38555)

      1. Using Google Chrome log into the site as a site admin.
      2. Go to any course.
      3. Turn editing on.
      4. Add a new activity, and select Forum.
      5. Do not type in a name for the forum (so that client-side validation failure occurs).
      6. Scroll down and click Save and return to course.
        EXPECTED: The validation error You must supply a value here should show. At the bottom of the page, the Save and return to course and Save and display buttons are still enabled.
      7. Type in a name for the forum, for example, "Forum 1".
      8. Scroll down and double click Save and return to course.
        EXPECTED: When the course page loads you should see just one instance of the new forum.
      Show
      (Based on the testing instructions from MDL-38555 ) Using Google Chrome log into the site as a site admin. Go to any course. Turn editing on. Add a new activity, and select Forum . Do not type in a name for the forum (so that client-side validation failure occurs). Scroll down and click Save and return to course . EXPECTED : The validation error You must supply a value here should show. At the bottom of the page, the Save and return to course and Save and display buttons are still enabled. Type in a name for the forum, for example, "Forum 1". Scroll down and double click Save and return to course . EXPECTED : When the course page loads you should see just one instance of the new forum.

      When submitting an assignment the Save changes and Cancel buttons are not disabled when using the Chrome browser. According to MDL-38555 they should get disabled, and this is what happens with Firefox.

      A customer who reported this sees this specifically with mod_assign but this may be a wider problem with form submission.

      Browsers tested:

      • Chrome 122.0.6261.95 on Microsoft Windows 10 (problem occurs)
      • Chromium 122.0.6261.94 on Fedora Linux 37 (problem occurs)
      • Firefox 123.0 on Microsoft Windows 10 (problem does not occur)
      • Firefox 120.0.1 on Fedora Linux 37 (problem does not occur)

      Steps to reproduce issue

      1. Create a course and enrol a student.
      2. Add an assignment to the course:
        1. Give it a name, for example, "Assignment 1".
        2. Submission types: "Online text"
        3. Feedback types: "Feedback comments"
      3. As the student:
        1. Log into Moodle using the Chrome browser.
        2. Click on the assignment from the course page.
        3. Click Add submission.
        4. Type some text in the editor field ("test").
        5. Double click on Save changes.

      Expected results

      The Save changes button is disabled after the first click so the second click has no effect. The assignment is submitted with no error message.

      Actual results

      The error You have existing submission data. Please leave this page and try again. appears. This problem is more prone to happen when the submission is not immediate as the enabled Save changes button remains clickable by an impatient student (for example, with a large file upload, or where the submission is sent to a third party API for evaluation).

            leonstr Leon Stringer
            leonstr Leon Stringer
            Sam Marshall Sam Marshall
            Huong Nguyen Huong Nguyen
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 29 minutes
                29m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.