Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-81194

Perform a complete PHPCompatibility 8.3 execution against codebase

    XMLWordPrintable

Details

    • Task
    • Resolution: Done
    • Minor
    • 4.4
    • 4.4
    • General
    • None

    Description

      This task is one of the final ones to perform when everything else in the epic has been already applied.

      It's about to run the PHPCompatibility standard (that we usually also run as part of our local_codechecker) against the whole codebase.

      Prerequisites:

      1. The epic must be almost finished (to avoid detecting problems that correspond to other issues).
      2. PHPCompatibility must support the php versions being checked.
      3. Determine the range of PHP versions supported for the branch (8.1-8.3). See MDL-78496 for 4.4 reqs.

      To perform the run against master, just:

      1. Clone https://github.com/PHPCompatibility/PHPCompatibility locally.
      2. Ensure you're in the "develop" branch (the "master" branch contains the latest release, quite old now 2019).
      3. run composer install
      4. Run:

        export DIRROOT=/path/to/your/moodle ; vendor/bin/phpcs \
            --standard=PHPCompatibility \
            --runtime-set testVersion 8.1-8.3 \
            --extensions=php \
            --ignore=$DIRROOT/vendor/,$DIRROOT/local/ \
            --cache=/tmp/cache -p $DIRROOT
        

      5. Generate a RTF file with the report and start processing it.
      6. Look for detected stuff, discard false positives (it can be useful to look to the results of the previous ones (8.2 Epic - MDL-77104, 8.1 Epic - MDL-73587) to drag any decision already taken there to this issue.

      Important: Please, when processing the file, always try to drag (copy-paste) the notes from previous runs. I know that it's a little bit more of work, but it's way better than not having references from previous runs and having to re-check the same again. It's only ~70 files/notes. Please!

      Attachments

        Issue Links

          Activity

            People

              stronk7 Eloy Lafuente (stronk7)
              stronk7 Eloy Lafuente (stronk7)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 5 hours, 1 minute
                  5h 1m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.