Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-81213

Fix .form-control elements width

XMLWordPrintable

    • MOODLE_404_STABLE
    • MOODLE_404_STABLE
    • MDL-81213-main
    • Hide

      Setup

      1. Login as administrator
      2. Create a course

      Test

      1. Click on Profile under user menu
      2. Click on Edit profile
      3. Confirm that the form elements are not displayed in full width
      4. Go to the created course
      5. Click on Settings tab
      6. Confirm that the form elements are not displayed in full width
      7. Click on Reports under user menu
      8. Click on New report
      9. Confirm that the form elements are not displayed in full width
      Show
      Setup Login as administrator Create a course Test Click on Profile under user menu Click on Edit profile Confirm that the form elements are not displayed in full width Go to the created course Click on Settings tab Confirm that the form elements are not displayed in full width Click on Reports under user menu Click on New report Confirm that the form elements are not displayed in full width
    • 1
    • HQ 2024 Sprint I1.3 Moppies

      In MDL-75670 .form-inline and .form-group Bootstrap classes were removed from the codebase as preparation work for the Bootstrap 5 upgrade. Those classes will be dropped in BS5 and the migration guide suggests replacing them using the grid system.

      That change in our codebase resulted in a change in some of the forms now having full width. That is happening because this block no longer matches with the previous defined ".form-inline"s, and it is not applying display: inline-block; width: auto; styles to the .form-control elements.

      Before MDL-75670

      After MDL-75670

        1. (1) 3 Passed -- (Main)MDL-81213.png
          (1) 3 Passed -- (Main)MDL-81213.png
          56 kB
        2. (1) 6 Passed -- (Main)MDL-81213.png
          (1) 6 Passed -- (Main)MDL-81213.png
          68 kB
        3. (1) 9 Passed -- (Main)MDL-81213.png
          (1) 9 Passed -- (Main)MDL-81213.png
          45 kB
        4. screenshot-1.png
          screenshot-1.png
          81 kB
        5. screenshot-2.png
          screenshot-2.png
          82 kB
        6. screenshot-3.png
          screenshot-3.png
          76 kB
        7. screenshot-4.png
          screenshot-4.png
          87 kB
        8. screenshot-5.png
          screenshot-5.png
          66 kB

            mikelmartíncorrales Mikel Martín Corrales
            mikelmartíncorrales Mikel Martín Corrales
            Paul Holden Paul Holden
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 48 minutes
                2h 48m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.