Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-8123

Admin_tree icons not read from theme pix folder

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 1.7
    • 1.8.5, 1.9
    • Administration, Themes
    • None
    • All platforms and environemnts
    • MOODLE_17_STABLE
    • MOODLE_18_STABLE, MOODLE_19_STABLE

    Description

      Unlike all the other icon files the open.gif, closed.gif and item.gif used in the admin tree are not used if present in the pix folder under the used theme folder.

      The lines that seem to be causing this are in blocks\admin_tree\block_admin_tree.php:

      38: $this->tempcontent .= '<span id="vh_span' . $this->spancounter . 'indicator"><img src="' . $CFG->wwwroot . '/blocks/admin_tree/open.gif" border="0" alt="[open folder]" /></span> ';

      63: $this->create_item($content->visiblename,$CFG->wwwroot.'/'.$CFG->admin.'/settings.php?section=' . $content->name,$CFG->wwwroot .'/blocks/admin_tree/item.gif', $class);

      68: $this->create_item($content->visiblename, $content->url, $CFG->wwwroot . '/blocks/admin_tree/item.gif', $class);

      145: $this->content->text .= ' getspan(spanid + "indicator").innerHTML = \'<img src="' . $CFG->wwwroot . '/blocks/admin_tree/open.gif" border="0" alt="'.$strfolderopened.'" />\';' . "\n";

      149: $this->content->text .= ' getspan(spanid + "indicator").innerHTML = \'<img src="' . $CFG->wwwroot . '/blocks/admin_tree/closed.gif" border="0" alt="'.$strfolderclosed.'" />\';' . "\n";

      157: $this->content->text .= ' getspan(spanid + "indicator").innerHTML = \'<img src="' . $CFG->wwwroot . '/blocks/admin_tree/closed.gif" border="0" alt="'.$strfolderclosed.'" />\';' . "\n";

      163: $this->content->text .= ' getspan(spanid + "indicator").innerHTML = \'<img src="' . $CFG->wwwroot . '/blocks/admin_tree/open.gif" border="0" alt="'.$strfolderopened.'" />\';' . "\n";

      Attachments

        Issue Links

          Activity

            People

              scyrma Mathieu Petit-Clair
              redmorris Red Morris
              Sam Hemelryk Sam Hemelryk
              Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Stevani Andolo, Huong Nguyen, Bas Brands, Mathew May
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                3/Mar/08