Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-8130

blackboard 5 question import html entity and question name length safety [patch]

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Fixed
    • Minor
    • 1.7.1, 1.8
    • 1.7
    • Questions
    • None
    • Linux, PostgreSQL 7 backend
    • PostgreSQL
    • MOODLE_17_STABLE
    • MOODLE_17_STABLE, MOODLE_18_STABLE

    Description

      I was attempting to import questions using the blackboard 5 type that a faculty member was having problems with and the import was silently dying during the process. After turning on debugging I saw that the question->name field was simply too big >255 for the field in the database. I fixed that in the code by truncating the name to 254 characters. Also in this patch I check to see if the questions are already in HTML encoded format, and if so, I re-interpret the HTML entities so that things like ৻ are the actual character rather than code when printed to the screen. Attached is a test case and my patch.

      Attachments

        1. fil0.dat
          4 kB
          Paul Ortman
        2. html_entities_and_question_name_safety_2.diff
          7 kB
          Paul Ortman
        3. html_entities_and_question_name_safety.diff
          3 kB
          Paul Ortman

        Issue Links

          Activity

            People

              howardsmiller Howard Miller
              paul.ortman Paul Ortman
              Nobody Nobody
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Clockify

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.